Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.gradio: relax aiofiles and markupfiles #352893

Merged
merged 1 commit into from
Nov 2, 2024
Merged

python312Packages.gradio: relax aiofiles and markupfiles #352893

merged 1 commit into from
Nov 2, 2024

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Nov 1, 2024 •
edited
Loading

fixes https://hydra.nixos.org/build/276677105

I also pushed the fix to the bump in #349625, but it is technically a breaking change /shrug

ZHF #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review November 1, 2024 15:19
@pbsds pbsds mentioned this pull request Nov 1, 2024
Merged
13 tasks
@pbsbot
Copy link

pbsbot commented Nov 1, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352893

x86_64-linux

❌ 6 packages failed to build:
  • private-gpt
  • private-gpt.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

@gepbird gepbird added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 1, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 1, 2024
GaetanLepage
GaetanLepage approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank merged commit f2d93e4 into NixOS:master Nov 2, 2024
42 of 44 checks passed
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352893

x86_64-linux

❌ 6 packages failed to build:
  • private-gpt
  • private-gpt.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

aarch64-linux

⏩ 6 packages marked as broken and skipped:
  • private-gpt
  • private-gpt.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

x86_64-darwin

⏩ 6 packages marked as broken and skipped:
  • private-gpt
  • private-gpt.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

aarch64-darwin

⏩ 6 packages marked as broken and skipped:
  • private-gpt
  • private-gpt.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

@pbsds pbsds mentioned this pull request Nov 2, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pbsds @pbsbot @GaetanLepage @wegank @gepbird