{nixos/gpu-screen-recorder,gpu-screen-recorder{-,gtk}}: update to 4.1.11, remove `cap_sys_nice` #339874

DontEatOreo · 2024-09-05T18:59:55Z

Description of changes

Update gpu-screen-recorder{-,gtk} to 4.1.11
Use lib.mesonBool in mesonFlags = [ ... ]
Add addDriverRunpath.driverLink to LD_LIBRARY_PATH for both
{nixos/gpu-screen-recorder,gpu-screen-recorder{-,gtk}}: update to 4.1.11, remove cap_sys_nice #339874 (comment)
Remove patch 0001-Don-t-install-systemd-unit-files-using-absolute-path as it's no longer needed (surpass by (lib.mesonBool "systemd" false))

Things done

Add a 👍 reaction to pull requests you find important.

DontEatOreo · 2024-09-05T19:27:41Z

Result of nixpkgs-review pr 339874 --extra-nixpkgs-config '{ allowAliases = false; allowBroken = false; allowUnfree = true; checkMeta = true; cudaSupport = false; cudaCapabilities = [ ]; }' run on x86_64-linux 1

1 package blacklisted:

nixos-install-tools

3 packages built:

disko
gpu-screen-recorder
gpu-screen-recorder-gtk

nixos/modules/programs/gpu-screen-recorder.nix

DontEatOreo · 2024-09-06T11:49:07Z

@JohnRTitor Could you take a look?

~~I'm not really sure if this is the proper way to do it...~~

https://github.com/NixOS/nixpkgs/blob/5b1d68c9d72e3c757bd8636e80a597a4fd4e7b0a/nixos/modules/programs/gpu-screen-recorder.nix#L49-L53

Edit: I would imagine this would be a better approach

https://github.com/NixOS/nixpkgs/blob/e8124145144f8db8b3f0a625a4849eac09463be3/nixos/modules/programs/gpu-screen-recorder.nix#L28-L38

https://github.com/NixOS/nixpkgs/blob/e8124145144f8db8b3f0a625a4849eac09463be3/nixos/modules/programs/gpu-screen-recorder.nix#L54-L56

...ns/video/gpu-screen-recorder/0001-Don-t-install-systemd-unit-files-using-absolute-path.patch

pkgs/applications/video/gpu-screen-recorder/default.nix

nixos/modules/programs/gpu-screen-recorder.nix

keenanweaver · 2024-10-05T22:13:46Z

Should the packages use the unstable updater? I believe @dec05eba wants users to use the latest commit to master.

DontEatOreo · 2024-10-05T22:23:34Z

Thanks for the additional reviews! Tomorrow, I will take a look and try to implement the suggestions

dec05eba · 2024-10-06T00:32:38Z

Should the packages use the unstable updater? I believe @dec05eba wants users to use the latest commit to master.

These days gpu screen recorder has proper versions and I now also created a tag for the latest release and will continue doing so for new releases. The tag is now visible here: https://git.dec05eba.com/gpu-screen-recorder/ (version 4.1.11). I recommend using the latest release instead of master now. There is also a changelog for versions available here: https://git.dec05eba.com/gpu-screen-recorder-gtk/tree/com.dec05eba.gpu_screen_recorder.appdata.xml#n82

pkgs/applications/video/gpu-screen-recorder/default.nix

pkgs/applications/video/gpu-screen-recorder/gpu-screen-recorder-gtk.nix

keenanweaver

You'll also need to close the finalAttrs portion, can't seem to add it to the Github review for whatever reason.

pkgs/applications/video/gpu-screen-recorder/gpu-screen-recorder-gtk.nix

pkgs/applications/video/gpu-screen-recorder/default.nix

Co-authored-by: Keenan Weaver <[email protected]>

DontEatOreo · 2024-10-06T12:18:21Z

I’ve decided to drop the module refactor from this PR. I'll need more time to think it through and implement it properly. I don’t want to slow down this PR any further, so I’ll create another PR in the near future for the module

nixos/modules/programs/gpu-screen-recorder.nix

Reason: NixOS#339874 (comment) Co-authored-by: dec05eba <[email protected]>

DontEatOreo · 2024-10-06T12:58:26Z

Result of nixpkgs-review pr 339874 --extra-nixpkgs-config '{ allowAliases = false; allowBroken = false; allowUnfree = true; checkMeta = true; cudaSupport = true; cudaCapabilities = [ "7.5" ]; }' run on x86_64-linux 1

1 package blacklisted:

nixos-install-tools

2 packages built:

gpu-screen-recorder
gpu-screen-recorder-gtk

keenanweaver · 2024-10-06T13:00:16Z

Result of nixpkgs-review pr 339874 run on x86_64-linux 1

1 package blacklisted:

nixos-install-tools

2 packages built:

gpu-screen-recorder
gpu-screen-recorder-gtk

SuperSandro2000 · 2024-10-06T13:10:02Z

pkgs/applications/video/gpu-screen-recorder/gpu-screen-recorder-gtk.nix

+    ''
+      gappsWrapperArgs+=(--prefix PATH : ${wrapperDir})
+      gappsWrapperArgs+=(--suffix PATH : ${lib.makeBinPath [ gpu-screen-recorder-wrapped ]})
+      gappsWrapperArgs+=(--prefix LD_LIBRARY_PATH : ${


We cannot use patchelf?

I'm not exactly sure how that would be implemented..

SuperSandro2000 · 2024-10-06T13:10:13Z

pkgs/applications/video/gpu-screen-recorder/gpu-screen-recorder-gtk.nix

+      };
+    in
+    ''
+      gappsWrapperArgs+=(--prefix PATH : ${wrapperDir})


We can amend a list to the var

keenanweaver · 2024-10-06T13:14:01Z

Trying to run it, I get this:

┌───────────────────>
│keenan in results/gpu-screen-recorder/bin🔒
❄️ bsh ›
└─>./gpu-screen-recorder -w screen -f 60 -a default_output -o "$HOME/Videos/video.mp4"
amdgpu: amdgpu_cs_ctx_create2 failed. (-13)
Info: using h264 encoder because a codec was not specified
gsr info: gsr_kms_client_init: waiting for server to connect
kms server info: connecting to the client
gsr info: gsr_kms_client_init: server connected
gsr info: replacing file-backed unix domain socket with socketpair
kms server info: connected to the client
kms server error: expected gpu screen recorder protocol version to be 2, but it's 4

^Cgsr error: gsr_kms_client_replace_connection: failed to receive response
gsr error: gsr_capture_start failed

Recording file doesn't get written. Don't know if it's because of my current gpu-screen-recorder instance. (I have a systemd service for replay autostart which I stopped for testing this.) But the package builds fine to 4.1.11. The 'current' gpu-screen-recorder records fine.

System info:

          ▗▄▄▄       ▗▄▄▄▄    ▄▄▄▖             keenan@nixos-desktop
          ▜███▙       ▜███▙  ▟███▛             --------------------
           ▜███▙       ▜███▙▟███▛              OS: NixOS 24.11.20241004.bc947f5 (Vicuna) x86_64
            ▜███▙       ▜██████▛               Kernel: Linux 6.11.1
     ▟█████████████████▙ ▜████▛     ▟▙         Uptime: 25 mins
    ▟███████████████████▙ ▜███▙    ▟██▙        Packages: 2614 (nix-system), 158 (flatpak-user)
           ▄▄▄▄▖           ▜███▙  ▟███▛        Shell: zsh 5.9
          ▟███▛             ▜██▛ ▟███▛         Display (XB271HU): 2560x1440 @ 165 Hz in 27″ [External]
         ▟███▛               ▜▛ ▟███▛          Display (LEN Y27q-20): 2560x1440 @ 165 Hz in 27″ [External] *
▟███████████▛                  ▟██████████▙    DE: KDE Plasma
▜██████████▛                  ▟███████████▛    WM: KWin (Wayland)
      ▟███▛ ▟▙               ▟███▛             WM Theme: Klassy
     ▟███▛ ▟██▙             ▟███▛              Theme: Klassy (CatppuccinMochaLavender) [Qt]
    ▟███▛  ▜███▙           ▝▀▀▀▀               Icons: Papirus-Dark [Qt], Papirus-Dark [GTK2]
    ▜██▛    ▜███▙ ▜██████████████████▛         Font: Inter (12pt) [Qt], Inter (12pt) [GTK2/3/4]
     ▜▛     ▟████▙ ▜████████████████▛          Cursor: breeze (24px)
           ▟██████▙       ▜███▙                Terminal: WezTerm 20240203-110809-5046fc22
          ▟███▛▜███▙       ▜███▙               Terminal Font: JetBrainsMono Nerd Font
         ▟███▛  ▜███▙       ▜███▙              CPU: AMD Ryzen 7 5800X (16) @ 4.85 GHz
         ▝▀▀▀    ▀▀▀▀▘       ▀▀▀▘              GPU: AMD Radeon RX 7900 XTX [Discrete]
                                               Memory: 8.14 GiB / 31.27 GiB (26%)
                                               Swap: 3.00 MiB / 7.82 GiB (0%)
                                               Disk (/): 1.23 MiB / 8.00 GiB (0%) - tmpfs
                                               Disk (/home/keenan/Games): 814.53 GiB / 1.82 TiB (44%) - btrfs
                                               Disk (/persist): 289.83 GiB / 1.82 TiB (16%) - btrfs
                                               Local IP (enp10s0): 10.20.1.8/24
                                               Locale: en_US.UTF-8

Can anyone else confirm similar issues?

dec05eba · 2024-10-06T13:54:54Z

Trying to run it, I get this:

You need to install the program rather than run it locally in the directory. gpu screen recorder will launch gsr-kms-server (also installed by gpu screen recorder) from PATH and the version of gsr-kms-server needs to match the version in gpu screen recorder. If you are running a local version of gpu screen recorder but have another version installed on the system then it can fail if there are changes between the versions.

keenanweaver · 2024-10-06T14:17:48Z

Trying to run it, I get this:

You need to install the program rather than run it locally in the directory. gpu screen recorder will launch gsr-kms-server (also installed by gpu screen recorder) from PATH and the version of gsr-kms-server needs to match the version in gpu screen recorder. If you are running a local version of gpu screen recorder but have another version installed on the system then it can fail if there are changes between the versions.

Lo and behold, the author is correct! Working great for me in 'normal' and 'replay' modes.

keenanweaver

Bumping to latest

pkgs/applications/video/gpu-screen-recorder/default.nix

pkgs/applications/video/gpu-screen-recorder/gpu-screen-recorder-gtk.nix

pkgs/applications/video/gpu-screen-recorder/default.nix

pkgs/applications/video/gpu-screen-recorder/gpu-screen-recorder-gtk.nix

Co-authored-by: Keenan Weaver <[email protected]>

dec05eba · 2024-10-13T17:47:38Z

vulkan-headers is a new dependency that should be added for gpu-screen-recorder (build dependency)

keenanweaver

Added vulkan-headers per #339874 (comment) Confirmed building

pkgs/applications/video/gpu-screen-recorder/default.nix

DontEatOreo · 2024-10-14T13:04:08Z

Result of nixpkgs-review pr 339874 --extra-nixpkgs-config '{ allowAliases = false; allowBroken = false; allowUnfree = true; checkMeta = true; cudaSupport = true; cudaCapabilities = [ "7.5" ]; }' run on x86_64-linux 1

1 package blacklisted:

nixos-install-tools

2 packages built:

gpu-screen-recorder
gpu-screen-recorder-gtk

DontEatOreo · 2024-10-24T12:06:18Z

Superseeds #335546

pkgs/applications/video/gpu-screen-recorder/default.nix

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 5, 2024

DontEatOreo changed the title ~~{nixos/gpu-screen-recorder,gpu-screen-recorder-{,gtk}}: update to {09-03,09-02}, add systemd serviceand nvidia fix to module~~ {nixos/gpu-screen-recorder,gpu-screen-recorder-{,gtk}}: update to {09-03,09-02}, add systemd service and nvidia fix to module Sep 5, 2024

DontEatOreo force-pushed the update-gpu-screen-recorder branch from eef7b0c to eb7d78c Compare September 5, 2024 19:34

ofborg bot requested a review from babbaj September 5, 2024 20:22

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 5, 2024

dec05eba reviewed Sep 5, 2024

View reviewed changes

nixos/modules/programs/gpu-screen-recorder.nix Outdated Show resolved Hide resolved

DontEatOreo force-pushed the update-gpu-screen-recorder branch from eb7d78c to 5b1d68c Compare September 5, 2024 22:24

sarcasticadmin mentioned this pull request Sep 7, 2024

auto-cpufreq: 2.3.0 -> 2.4.0 #339771

Merged

13 tasks

DontEatOreo changed the title ~~{nixos/gpu-screen-recorder,gpu-screen-recorder-{,gtk}}: update to {09-03,09-02}, add systemd service and nvidia fix to module~~ {nixos/gpu-screen-recorder,gpu-screen-recorder{-,gtk}}: update to {09-03,09-02}, add systemd service and nvidia fix to module Sep 8, 2024

DontEatOreo force-pushed the update-gpu-screen-recorder branch from 5b1d68c to 94c83f9 Compare September 9, 2024 12:53

SuperSandro2000 reviewed Sep 11, 2024

View reviewed changes

DontEatOreo force-pushed the update-gpu-screen-recorder branch from 94c83f9 to 22c443c Compare September 11, 2024 14:42

keenanweaver reviewed Oct 5, 2024

View reviewed changes

nixos/modules/programs/gpu-screen-recorder.nix Outdated Show resolved Hide resolved

nixos/modules/programs/gpu-screen-recorder.nix Outdated Show resolved Hide resolved

dec05eba reviewed Oct 5, 2024

View reviewed changes

nixos/modules/programs/gpu-screen-recorder.nix Outdated Show resolved Hide resolved

keenanweaver reviewed Oct 6, 2024

View reviewed changes

keenanweaver suggested changes Oct 6, 2024

View reviewed changes

DontEatOreo and others added 7 commits October 6, 2024 15:05

gpu-screen-recorder: unstable-2024-07-05 -> 4.1.11

90dfc4d

Co-authored-by: Keenan Weaver <[email protected]>

gpu-screen-recorder: add finalAttrs pattern

9a6c897

Co-authored-by: Keenan Weaver <[email protected]>

gpu-screen-recorder: sort meta

c9ea67f

gpu-screen-recorder-gtk: format with nixfmt-rfc-style

28f19a4

gpu-screen-recorder-gtk: unstable-2024-07-05 -> 4.1.11

2a0a0c1

Co-authored-by: Keenan Weaver <[email protected]>

gpu-screen-recorder-gtk: add finalAttrs pattern

2e74ecd

Co-authored-by: Keenan Weaver <[email protected]>

gpu-screen-recorder-gtk: sort meta

5668a1c

DontEatOreo changed the title ~~{nixos/gpu-screen-recorder,gpu-screen-recorder{-,gtk}}: update to {09-03,09-02}, add systemd service and nvidia fix to module~~ {nixos/gpu-screen-recorder,gpu-screen-recorder{-,gtk}}: update to 4.1.11, remove cap_sys_nice Oct 6, 2024

dec05eba reviewed Oct 6, 2024

View reviewed changes

nixos/modules/programs/gpu-screen-recorder.nix Outdated Show resolved Hide resolved

DontEatOreo and others added 2 commits October 6, 2024 15:27

nixos/gpu-screen-recorder: format with nixfmt-rfc-style

8d56419

nixos/gpu-screen-recorder: remove cap_sys_nice

7b69d08

Reason: NixOS#339874 (comment) Co-authored-by: dec05eba <[email protected]>

DontEatOreo force-pushed the update-gpu-screen-recorder branch 2 times, most recently from eaae587 to 7b69d08 Compare October 6, 2024 12:30

SuperSandro2000 reviewed Oct 6, 2024

View reviewed changes

keenanweaver approved these changes Oct 6, 2024

View reviewed changes

DontEatOreo requested a review from JohnRTitor October 10, 2024 10:25

keenanweaver suggested changes Oct 12, 2024

View reviewed changes

DontEatOreo and others added 2 commits October 13, 2024 20:29

gpu-screen-recorder: 4.1.11 -> 4.2.1

9affa2c

Co-authored-by: Keenan Weaver <[email protected]>

gpu-screen-recorder-gtk: 4.1.11 -> 4.2.1

04a6068

Co-authored-by: Keenan Weaver <[email protected]>

keenanweaver suggested changes Oct 13, 2024

View reviewed changes

pkgs/applications/video/gpu-screen-recorder/default.nix Show resolved Hide resolved

pkgs/applications/video/gpu-screen-recorder/default.nix Show resolved Hide resolved

DontEatOreo force-pushed the update-gpu-screen-recorder branch from 0c23c16 to 04a6068 Compare October 14, 2024 12:55

keenanweaver approved these changes Oct 14, 2024

View reviewed changes

JohnRTitor merged commit 18760e4 into NixOS:master Oct 14, 2024
28 of 29 checks passed

DontEatOreo deleted the update-gpu-screen-recorder branch October 14, 2024 21:11

DontEatOreo mentioned this pull request Oct 24, 2024

gpu-screen-recorder: unstable-2024-07-05 -> 4.1.2 #335546

Closed

13 tasks

timschumi reviewed Oct 24, 2024

View reviewed changes

pkgs/applications/video/gpu-screen-recorder/default.nix Show resolved Hide resolved

timschumi mentioned this pull request Oct 24, 2024

gpu-screen-recorder: Install the systemd unit again #350956

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

{nixos/gpu-screen-recorder,gpu-screen-recorder{-,gtk}}: update to 4.1.11, remove `cap_sys_nice` #339874

{nixos/gpu-screen-recorder,gpu-screen-recorder{-,gtk}}: update to 4.1.11, remove `cap_sys_nice` #339874

DontEatOreo commented Sep 5, 2024 •

edited

Loading

DontEatOreo commented Sep 5, 2024

DontEatOreo commented Sep 6, 2024 •

edited

Loading

keenanweaver commented Oct 5, 2024

DontEatOreo commented Oct 5, 2024

dec05eba commented Oct 6, 2024 •

edited

Loading

keenanweaver left a comment

DontEatOreo commented Oct 6, 2024

DontEatOreo commented Oct 6, 2024

keenanweaver commented Oct 6, 2024

SuperSandro2000 Oct 6, 2024

DontEatOreo Oct 7, 2024

SuperSandro2000 Oct 6, 2024

keenanweaver commented Oct 6, 2024

dec05eba commented Oct 6, 2024 •

edited

Loading

keenanweaver commented Oct 6, 2024

keenanweaver left a comment

dec05eba commented Oct 13, 2024

keenanweaver left a comment

DontEatOreo commented Oct 14, 2024

DontEatOreo commented Oct 24, 2024

{nixos/gpu-screen-recorder,gpu-screen-recorder{-,gtk}}: update to 4.1.11, remove cap_sys_nice #339874

{nixos/gpu-screen-recorder,gpu-screen-recorder{-,gtk}}: update to 4.1.11, remove cap_sys_nice #339874

Conversation

DontEatOreo commented Sep 5, 2024 • edited Loading

Description of changes

Things done

DontEatOreo commented Sep 5, 2024

DontEatOreo commented Sep 6, 2024 • edited Loading

keenanweaver commented Oct 5, 2024

DontEatOreo commented Oct 5, 2024

dec05eba commented Oct 6, 2024 • edited Loading

keenanweaver left a comment

Choose a reason for hiding this comment

DontEatOreo commented Oct 6, 2024

DontEatOreo commented Oct 6, 2024

keenanweaver commented Oct 6, 2024

SuperSandro2000 Oct 6, 2024

Choose a reason for hiding this comment

DontEatOreo Oct 7, 2024

Choose a reason for hiding this comment

SuperSandro2000 Oct 6, 2024

Choose a reason for hiding this comment

keenanweaver commented Oct 6, 2024

dec05eba commented Oct 6, 2024 • edited Loading

keenanweaver commented Oct 6, 2024

keenanweaver left a comment

Choose a reason for hiding this comment

dec05eba commented Oct 13, 2024

keenanweaver left a comment

Choose a reason for hiding this comment

DontEatOreo commented Oct 14, 2024

DontEatOreo commented Oct 24, 2024

{nixos/gpu-screen-recorder,gpu-screen-recorder{-,gtk}}: update to 4.1.11, remove `cap_sys_nice` #339874

{nixos/gpu-screen-recorder,gpu-screen-recorder{-,gtk}}: update to 4.1.11, remove `cap_sys_nice` #339874

DontEatOreo commented Sep 5, 2024 •

edited

Loading

DontEatOreo commented Sep 6, 2024 •

edited

Loading

dec05eba commented Oct 6, 2024 •

edited

Loading

dec05eba commented Oct 6, 2024 •

edited

Loading