Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-cpufreq: 2.3.0 -> 2.4.0 #339771

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

isabelroses
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from sarcasticadmin September 5, 2024 11:43
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 5, 2024
@sarcasticadmin
Copy link
Member

Result of nixpkgs-review pr 339771 run on x86_64-linux 1

2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
3 packages built:
  • auto-cpufreq
  • auto-cpufreq.dist
  • disko

@isabelroses isabelroses added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 6, 2024
Copy link
Member

@sarcasticadmin sarcasticadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is odd why disko is being included in the results for the build. Going to look into this a bit more.

@sarcasticadmin sarcasticadmin removed 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 7, 2024
@isabelroses
Copy link
Member Author

It is odd why disko is being included in the results for the build. Going to look into this a bit more.

I would imagine its beacuse disko needs nixos-install-tools and this package has always seemed to trigger nixos-install-tools and tests.nixos-functions.nixos-test to build

@sarcasticadmin
Copy link
Member

sarcasticadmin commented Sep 7, 2024

@isabelroses I see what you mean: #315383

It looks like other PRs also have disko showing up in their results too: #339874 (comment)

Ill approve this given this seems to be caused by something else

@sarcasticadmin sarcasticadmin self-requested a review September 7, 2024 13:07
@sarcasticadmin sarcasticadmin added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Sep 7, 2024
@minijackson minijackson merged commit e293846 into NixOS:master Sep 8, 2024
31 of 32 checks passed
@isabelroses isabelroses deleted the pkgs/auto-cpufreq/update branch September 8, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants