azuredatastudio: 1.48.1 -> 1.49.1 #336114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates azuredatastudio to the latest version. It also pins the version, because the maintainers switched to a new build deployment solution the old way of retrieving pinned builds did'nt work anymore, resulting in breaking package builds because the hash would not match.
13 tasks
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
10.rebuild-darwin: 0
|
Result of 1 package built:
|
Daru-san
approved these changes
Aug 21, 2024
wegank
added
the
12.approvals: 1
|
Result of 1 package built:
|
hauskens
approved these changes
Aug 21, 2024
hauskens
added
12.approvals: 2
fabianhjr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #334220, originally opened by @gaelj.
This updates azuredatastudio to the latest version.
It also pins the version, because the maintainers switched to a new build deployment solution the old way of retrieving pinned builds didn't work anymore, resulting in breaking package builds because the hash would not match.
See microsoft/azuredatastudio#25735 for more details about the new way of retrieving the download URL (I also put this as a comment in the file itself, so future maintainers can easily find it)
Description of changes
Update azuredatastudio from 1.48.1 to 1.49.1
Things done
Change the URL to the tarball that contains the Azuredatastudio build. Also changed the path to the sqltoolsservice because that often changes when a new version is released.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.