azuredatastudio: 1.48.1 -> 1.49.0 (fixes hash mismatch)

[gaelj]

Description of changes

Dear maintainer @xavierzwirtz

I got a hash mismatch error when trying to install azure data studio on unstable.

After fixing the hash error (and remaining on the same version, 1.48.1), I got a new error about sqltoolsservicePath not being found (because it was expecting version 5.0.20240724.1 instead of 4.11.1.1), so I corrected it as well.

This got it working on my machine, a QEmu x64 VM.

Then I noticed that the installed version was actually 1.49.0, even though the download link was pointing to 1.48.1. So I corrected the version tag as well.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[hauskens]

Result of nixpkgs-review pr 334220 run on x86_64-linux 1

1 package built:

• azuredatastudio

[Daru-san]

Thanks for doing this. Could you please rebase your commits when merging/syncing your branch with the master branch?

[Daru-san]

Other than that it all looks good to me 👍

[gaelj]

I rebased and squashed into a single commit that hopefully respects the guidelines.

[Daru-san]

Cool. Thank you

[Rutgerdj]

The problem is that the download link always provides the latest version, even when you put in an older version string.

A few days ago a new version of ADS has been released (1.49.1), so this PR doesn't work anymore.

I have asked if there is a way to download a specific build of ADS on the ADS repo:
microsoft/azuredatastudio#25735 (comment)

[gaelj]

@Rutgerdj I tried the proposed method on your link and did not get any joy. I notified it in that thread - hoping they can help us out.

[Rutgerdj]

Yeah the proposed method only works for old (archived) builds I assumed

[gaelj]

On vacation right now so I won't be able to apply the fix until next week.

…

On Sun, Aug 18, 2024, 15:18 Rutger ***@***.***> wrote: Yeah the proposed method only works for old (archived) builds I assumed — Reply to this email directly, view it on GitHub <#334220 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACDZDGEVDCVC5ZISK5IPPVDZSCNLDAVCNFSM6AAAAABMM3CCISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVGI3DAMJUGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Rutgerdj]

I can pick this up and integrate the new URL. Best is to create a new PR for it I think?

[SuperSandro2000]

The problem is that the download link always provides the latest version, even when you put in an older version string.

A few days ago a new version of ADS has been released (1.49.1), so this PR doesn't work anymore.

I have asked if there is a way to download a specific build of ADS on the ADS repo: microsoft/azuredatastudio#25735 (comment)

that please proxy the download through web.archive.org

[Rutgerdj]

that please proxy the download through web.archive.org
@SuperSandro2000

Is that common practice? We don't need it anymore for downloading specific versions.
I noticed that web.archive.org was down for a few hours. I don't know if that happens more often or that was just a coincidence.

[Rutgerdj]

@hauskens @Daru-san @xavierzwirtz I have created a PR (#336114) that solves the issue of the URL always pointing to the latest version.
Would be great if you could check it out, I think this PR can be abandoned