-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.05] cudnn: Fix referring to deprecated alias #335400
[24.05] cudnn: Fix referring to deprecated alias #335400
Conversation
Similar to commit ae5074e cudaPackages: fix an annoying warning caused by alias Can be verified with: NIX_ABORT_ON_WARN=true NIXPKGS_ALLOW_UNFREE=1 NIX_PATH=nixpkgs=. nix-instantiate -A cudaPackages.cudnn
Taking this also as an opportunity to show how very useless The relevant file that needed to be changed appears nowhere in the stack trace, nor did
|
@@ -127,6 +127,8 @@ let | |||
inherit pname; | |||
redistName = pname; | |||
inherit (shims) redistribRelease featureRelease; | |||
# get `autoAddDriverRunpath` from pkgs instead of cudaPackages' alias to avoid warning | |||
inherit (final.callPackage ({ pkgs }: pkgs) { }) autoAddDriverRunpath; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why such an indirect way to refer to pkgs.autoAddDriverRunpath
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this file doesn't get pkgs
from outside, so I get pkgs
via callPackage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough for me for 24.05, given that this whole thing is no longer necessary for 24.11.
@SomeoneSerge Good to merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for blacking out, yes it's alright
Merging as ofborg shows no rebuilds as expected. |
Similar to commit
CC @wrvsrx @niklaskorz @drupol from #316594
Can be verified with:
Without this change, it prints
for
cudnn
and any package that depends on it.Not necessary on
master
because commit bb429ba already removed the alias in PR:Things done
Add a 👍 reaction to pull requests you find important.