cudaPackages: drop outdated aliases #331017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
I'd also maybe start with the last item and check if there are any other components forcing evaluation to reach the traces. |
srhb
changed the title
|
@SomeoneSerge Oops, I raced you. Sure, let me do the version check instead. |
srhb
force-pushed
the
drop-cuda-aliases
branch
2 times, most recently
from
409a556 to
ab2d64d
Compare
|
@SomeoneSerge Alright, how's this? I had to jump some hoops to allow the empty aliases infrastructure to pass CI checks, but nothing too bad I suppose. |
Comment on lines
7
to
11
| # let | ||
| # mkRenamed = | ||
| # oldName: newName: newPkg: | ||
| # final.lib.warn "cudaPackages.${oldName} is deprecated, use ${newName} instead" newPkg; | ||
| # in |
There was a problem hiding this comment.
Ah, here we go: #331085
SomeoneSerge
force-pushed
the
drop-cuda-aliases
branch
2 times, most recently
from
3632982 to
6e7b739
Compare
SomeoneSerge
force-pushed
the
drop-cuda-aliases
branch
from
6e7b739 to
2a94466
Compare
ofborg
bot
added
10.rebuild-linux: 0
SomeoneSerge
changed the title
2 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Related to #306276
These traces are annoying in a lot of cases, and I think we should be good to remove them by now. I nuked all of aliases.nix for cuda-modules while I was at it. If this is heavy-handed, let me know.
For me personally, I could also live with removing this check in torch, which ends up triggering every alias in cudaPackages because of the equality check;
nixpkgs/pkgs/development/python-modules/torch/default.nix
Line 206 in 04404c0
But one or the other has to go. 😸
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.