-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openfoam-com: init at 2406 (plus 2312) #329213
base: master
Are you sure you want to change the base?
Conversation
05c80e7
to
e151284
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/package-openfoam-for-nixpkgs/47096/4 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4361 |
I recently found out that a dependency's derivation ( |
Description of changes
https://www.openfoam.com/
Closes #131486.
Please see the new doc section for additional info.
Getting OpenFOAM to build and be usable with nix has been a major headache, because it ships its own build system that has several non-standard assumptions about the environment.
I'm expecting feedback, because I'm sure there's stuff that can be patched/structured/done better, but I'm not sure how.
I have included the latest version at the time of writing, plus the previous version. Often OpenFOAM users stick with a specific version for sometime due to custom extensions. The way the derivation is structured, it can be easily overridden to compile an older version. Going forward I think we should probably only keep the latest 2 versions in nixpkgs.
This work has been sponsored by @nablaflow.
We've been using these derivations in production for ~6 months (
x86_64-linux
/aarch64-linux
).Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.