Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openfoam-com: init at 2406 (plus 2312) #329213

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

razielgn
Copy link
Contributor

@razielgn razielgn commented Jul 22, 2024

Description of changes

https://www.openfoam.com/

Closes #131486.

Please see the new doc section for additional info.

Getting OpenFOAM to build and be usable with nix has been a major headache, because it ships its own build system that has several non-standard assumptions about the environment.

I'm expecting feedback, because I'm sure there's stuff that can be patched/structured/done better, but I'm not sure how.

I have included the latest version at the time of writing, plus the previous version. Often OpenFOAM users stick with a specific version for sometime due to custom extensions. The way the derivation is structured, it can be easily overridden to compile an older version. Going forward I think we should probably only keep the latest 2 versions in nixpkgs.

This work has been sponsored by @nablaflow.
We've been using these derivations in production for ~6 months (x86_64-linux / aarch64-linux).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jul 22, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 22, 2024
@razielgn razielgn force-pushed the openfoam branch 4 times, most recently from 05c80e7 to e151284 Compare July 22, 2024 21:03
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/package-openfoam-for-nixpkgs/47096/4

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4361

@razielgn
Copy link
Contributor Author

I recently found out that a dependency's derivation (scotch) has recently been split out into $out and $dev.
This derivation still compiles but fails to see it and use it, resulting in a crash at runtime on a subset of binaries.
I will try to figure this out soon, it's not easy because the build scripts assume scothc's .sos and .hs files live in the same tree.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 29, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package OpenFOAM for FreeCAD's Cfd workbench
5 participants