python312Packages.jianpu-ly: init at 1.801 #328894
Merged
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
Sigmanificient
suggested changes
Aug 3, 2024
| buildPythonPackage rec { | ||
| pname = "jianpu-ly"; | ||
| version = "1.801"; | ||
| format = "setuptools"; |
There was a problem hiding this comment.
Suggested change
| format = "setuptools"; | |
| pyproject = true; |
| src = fetchPypi { | ||
| inherit version; | ||
| pname = "jianpu_ly"; | ||
| sha256 = "sha256-piK9Ym94cKdaHGz/ogX7ylyAF1ww0jCdRXnHN6lu2MI="; |
There was a problem hiding this comment.
Suggested change
| sha256 = "sha256-piK9Ym94cKdaHGz/ogX7ylyAF1ww0jCdRXnHN6lu2MI="; | |
| hash = "sha256-piK9Ym94cKdaHGz/ogX7ylyAF1ww0jCdRXnHN6lu2MI="; |
| sha256 = "sha256-piK9Ym94cKdaHGz/ogX7ylyAF1ww0jCdRXnHN6lu2MI="; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ lilypond ]; |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ lilypond ]; | |
| dependencies = [ lilypond ]; |
| # no tests in shipped with upstream | ||
| doCheck = false; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| meta = { |
Comment on lines
28
to
29
| license = licenses.asl20; | ||
| maintainers = with maintainers; [ ifurther ]; |
There was a problem hiding this comment.
Suggested change
| license = licenses.asl20; | |
| maintainers = with maintainers; [ ifurther ]; | |
| license = lib.licenses.asl20; | |
| maintainers = with lib.maintainers; [ ifurther ]; |
| description = "jianpu-ly is a Python program that assists with printing jianpu"; | ||
| license = licenses.asl20; | ||
| maintainers = with maintainers; [ ifurther ]; | ||
| platforms = platforms.all; |
There was a problem hiding this comment.
Uneeded for buildPythonPackage
Suggested change
| platforms = platforms.all; |
Comment on lines
21
to
26
| pythonImportsCheck = [ "jianpu_ly" ]; | ||
| # no tests in shipped with upstream |
There was a problem hiding this comment.
nit
Suggested change
| pythonImportsCheck = [ "jianpu_ly" ]; | |
| # no tests in shipped with upstream | |
| pythonImportsCheck = [ "jianpu_ly" ]; | |
| # no tests in shipped with upstream |
There was a problem hiding this comment.
This got already fixed in #325567 Please rebase your branch on master
ifurther
force-pushed
the
jianpu-ly
branch
4 times, most recently
from
0abab38 to
f835394
Compare
FliegendeWurst
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add jianpu-ly application
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.