Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.check-manifest: missing setuptools dependency #325567

Merged
merged 1 commit into from
Jul 11, 2024
Merged

python312Packages.check-manifest: missing setuptools dependency #325567

merged 1 commit into from
Jul 11, 2024

Conversation

con-f-use
Copy link
Contributor

@con-f-use con-f-use commented Jul 8, 2024 •
edited
Loading

closes #325565

Description of changes

Add setuptools to propagatedBuildInputs because it is a runtime dependency of this package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from nlewo July 8, 2024 16:28
@con-f-use
Copy link
Contributor Author

@nlewo

@nlewo nlewo merged commit 9e694d8 into NixOS:master Jul 11, 2024
46 checks passed
@con-f-use con-f-use deleted the check_manifest_add_setuptools branch July 12, 2024 07:19
@SuperSandro2000 SuperSandro2000 mentioned this pull request Aug 13, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python312Packages.check-manifest: missing runtime dependency on setuptools
2 participants
@con-f-use @nlewo