Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piped: init #326238

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

piped: init #326238

wants to merge 19 commits into from

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jul 11, 2024

Description of changes

Depends on #272380 and #326306

Closes #270008

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 11, 2024
@ofborg ofborg bot requested review from Defelo and chayleaf July 11, 2024 13:44
@ofborg ofborg bot requested review from liff and lorenzleutgeb July 11, 2024 13:44
data = ./deps.json;
};
passthru.updateDeps = gradle.updateDeps { inherit pname; };
passthru.updateScript = nix-update-script { extraArgs = [ "--version=branch=master" ]; };
Copy link
Contributor

@chayleaf chayleaf Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-update-script isn't enough here, as it doesn't update deps.json. Here's a working example for a different package:

passthru.updateScript = _experimental-update-script-combinators.sequence [
  (gitUpdater { rev-prefix = "v"; } // { attrPath = pname; })
  finalAttrs.passthru.updateDeps
];

@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Jul 15, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@aucub aucub closed this Dec 19, 2024
@Atemu
Copy link
Member Author

Atemu commented Dec 19, 2024

Sorry?

@Atemu Atemu reopened this Dec 19, 2024
@github-actions github-actions bot added the 6.topic: java Including JDK, tooling, other languages, other VMs label Dec 19, 2024
@Defelo Defelo mentioned this pull request Jan 1, 2025
13 tasks
stdenv,
fetchFromGitHub,
nodejs,
pnpm,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely you need to change pnpm to pnpm_9. Since #371832, it points to pnpm_10 instead of pnpm_9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: piped
7 participants