nixos/piped: init module #317817
Closed
nixos/piped: init module #317817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
|
Result of 1 package blacklisted:
3 packages built:
|
ofborg
bot
added
8.has: package (new)
h7x4
added
8.has: module (new)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4084 |
wegank
added
the
2.status: merge conflict
nbraud
reviewed
Sep 18, 2024
| root = pkgs.runCommand "piped-frontend-patched" {} '' | ||
| cp -r ${cfg.frontend.package} $out | ||
| chmod -R +w $out | ||
| ${pkgs.gnused}/bin/sed -i 's|https://pipedapi.kavin.rocks|${cfg.backend.externalUrl}|g' $out/{opensearch.xml,assets/*} |
There was a problem hiding this comment.
Suggested change
| ${pkgs.gnused}/bin/sed -i 's|https://pipedapi.kavin.rocks|${cfg.backend.externalUrl}|g' $out/{opensearch.xml,assets/*} | |
| ${lib.getExe pkgs.gnused} -i 's|https://pipedapi.kavin.rocks|${cfg.backend.externalUrl}|g' $out/{opensearch.xml,assets/*} |
or adding gnused to nativeBuildInputs
Comment on lines
+209
to
+213
| root = pkgs.runCommand "piped-frontend-patched" {} '' | ||
| cp -r ${cfg.frontend.package} $out | ||
| chmod -R +w $out | ||
| ${pkgs.gnused}/bin/sed -i 's|https://pipedapi.kavin.rocks|${cfg.backend.externalUrl}|g' $out/{opensearch.xml,assets/*} | ||
| ''; |
There was a problem hiding this comment.
It seems odd to do the rewriting in here. externalUrl could instead be a parameter for the piped package.
Comment on lines
+45
to
+70
| host = lib.mkOption { | ||
| type = lib.types.str; | ||
| default = "127.0.0.1"; | ||
| description = '' | ||
| The database host Piped should use. | ||
| ''; | ||
| }; | ||
|
|
||
| port = lib.mkOption { | ||
| type = lib.types.port; | ||
| default = config.services.postgresql.settings.port; | ||
| defaultText = lib.literalExpression "config.services.postgresql.settings.port"; | ||
| description = '' | ||
| The database port Piped should use. | ||
|
|
||
| Defaults to the the default postgresql port. | ||
| ''; | ||
| }; | ||
|
|
||
| database = lib.mkOption { | ||
| type = lib.types.str; | ||
| default = "piped"; | ||
| description = '' | ||
| The database Piped should use. | ||
| ''; | ||
| }; |
There was a problem hiding this comment.
This could be a single url option, which is what piped-backend's config uses anyhow.
Comment on lines
+127
to
+132
| domain = lib.mkOption { | ||
| type = lib.types.str; | ||
| description = '' | ||
| The domain Piped Backend is reachable on. | ||
| ''; | ||
| }; |
There was a problem hiding this comment.
Isn't that redundant with backend.externalUrl ?
|
Closing in favor of #326238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Piped is an alternative privacy-friendly YouTube frontend which is efficient by design.
This pull request adds packages for the Piped frontend, backend and proxy, as well as a NixOS module for setting up a Piped instance.
Homepage: https://github.com/TeamPiped/Piped/
Closes #270008
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.