Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove vrthra, cpages and lovek323 from meta.maintainers #324539

Merged
merged 6 commits into from
Jul 12, 2024
Merged

treewide: remove vrthra, cpages and lovek323 from meta.maintainers #324539

merged 6 commits into from
Jul 12, 2024

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jul 4, 2024

Description of changes

Since they are not active anymore.

#310759

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres
Copy link
Member Author

@vrthra gentle ping

@AndersonTorres AndersonTorres marked this pull request as ready for review July 4, 2024 11:34
@AndersonTorres AndersonTorres mentioned this pull request Jul 4, 2024
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 4, 2024
@bjornfor
Copy link
Contributor

bjornfor commented Jul 4, 2024

treewide: remove vrthra from meta.maintainers

Please explain in the commit message why.

@thiagokokada thiagokokada changed the title treewide: remove vrthra from meta.maintainers treewide: remove vrthra/lovek323 from meta.maintainers Jul 5, 2024
@AndersonTorres AndersonTorres changed the title treewide: remove vrthra/lovek323 from meta.maintainers treewide: remove vrthra and lovek323 from meta.maintainers Jul 5, 2024
@AndersonTorres
Copy link
Member Author

treewide: remove vrthra from meta.maintainers

Please explain in the commit message why.

Done

Tracking issue: #290642

Inactive since at least 2017 and 2022 respectively.
Tracking issue: #290642

Inactive since at least 2017.
@AndersonTorres AndersonTorres changed the title treewide: remove vrthra and lovek323 from meta.maintainers treewide: remove vrthra, cpages and lovek323 from meta.maintainers Jul 7, 2024
Copy link
Contributor

@superherointj superherointj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they ever want to come back, they can always re-add themselves.

@superherointj superherointj merged commit fe14ac8 into NixOS:master Jul 12, 2024
25 checks passed
@AndersonTorres
Copy link
Member Author

P.S.: some packages still refer to them. I am reworking these packages in other PRs, some of them into Staging.

@tie tie mentioned this pull request Jul 16, 2024
13 tasks
@bendlas
Copy link
Contributor

bendlas commented Aug 26, 2024

This removal PR has already been merged, despite not being grounded within community consensus. See #337478 (comment)

@vrthra @cpages @lovek323 be sure that we value your involvement and any time you may have to spare, helping with the packages you've maintained and others as well, and if you decide to come back, please don't hesitate to be added to maintainers again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 6.topic: ruby 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants