gdbm: rewrite and update #324436
gdbm: rewrite and update #324436
Conversation
ofborg
bot
requested review from
bjornfor,
amiloradovsky,
gebner,
prusnak,
cpages and
adevress
IMHO, when replacing meta.maintainers, there should be a comment in the commit message. I think "refactoring" means having internal changes and not external, but this commit changes the external interface (replacing maintainers, adding multiple outputs). |
@vrthra does not respond to pings anymore. I don't even know why the bots are calling so much people and still ignoring P.S.: #324539
I will think on a better name. |
|
The failure is unrelated |
wegank
added
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1857 |
- finalAttrs
- get rid of ${pname}
- split outputs
- strictDeps
- testVersion
- get rid of nested with
Why is this triggering infinite recursion wheh hashing is empty?
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1874 |
Description of changes
#324416
#324435
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.