Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ladybird: enable wayland support #324031

Merged
merged 1 commit into from
Jul 2, 2024
Merged

ladybird: enable wayland support #324031

merged 1 commit into from
Jul 2, 2024

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jul 2, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fgaz fgaz mentioned this pull request Jul 2, 2024
Closed
jchv
jchv approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@jchv jchv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + working on NixOS. Tested on kwin_wayland and SwayWM, tested with WAYLAND_DISPLAY= unset to test XWayland and DISPLAY= unset to test native Wayland, both working on both WMs. Build is already broken on Darwin, so not tested on Darwin (though the diff is pretty obviously safe.)

@eclairevoyant eclairevoyant added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 2, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 2, 2024
@fgaz fgaz merged commit dca246a into NixOS:master Jul 2, 2024
39 of 40 checks passed
@fgaz fgaz deleted the ladybird/wayland branch July 2, 2024 15:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchv jchv jchv approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgaz @jchv @eclairevoyant