ladybird: add GPU support

[nonetrix]

Describe the bug

The Ladybird package assumes it doesn't need GPU so if you run with --enable-gpu-painting it will return Configured to use GPU painter, but current platform does not have accelerated graphics I have had similar issues to this with other packages so I think that it is likely to be a issue with said Nix package

Steps To Reproduce

Steps to reproduce the behavior:

1. Run Ladybird with Ladybird --enable-gpu-painting
2. Observe

Expected behavior

It runs with GPU support and doesn't make errors

Screenshots

Additional context

I have AMD RX 6800 GPU and this seems like a experimental feature, also I am pretty sure QT can use the GPU as well so I think this might enable that? Benefit of that likely to be small at best but still

Notify maintainers

@fgaz

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
this path will be fetched (0.01 MiB download, 0.05 MiB unpacked):
  /nix/store/d3dzfy4amjl826fb8j00qp1d9887h7hm-stdenv-linux
copying path '/nix/store/d3dzfy4amjl826fb8j00qp1d9887h7hm-stdenv-linux' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 6.9.6, NixOS, 24.11 (Vicuna), 24.11.20240622.a71e967`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - channels(root): `"home-manager, nixos"`
 - nixpkgs: `/nix/store/yqy82fn77fy3rv7lpwa9m11w3a2nnqg5-source`

---

Add a 👍 reaction to issues you find important.

[nonetrix]

I assume Sika needs to be included? Just a guess

[fgaz]

Currently we disable hardware acceleration at compile time:

nixpkgs/pkgs/applications/networking/browsers/ladybird/default.nix

Lines 137 to 138 in 97c5d4c

	# FIXME: Enable this when launching with the commandline flag --enable-gpu-painting doesn't fail calling eglBindAPI on GNU/Linux
	"-DENABLE_ACCELERATED_GRAPHICS=OFF"

I'll try to enable it again and see if it works, after I do these higher priority tasks:

• ladybird: 0-unstable-2024-06-04 -> 0-unstable-2024-06-08 #318747
• ladybird: enable wayland support #324031
• ladybird: update to July 2024 version (skia) #325045

[nonetrix]

Ah sorry didn't catch that

[ADKaster]

Note that the ENABLE_ACCELERATED_GRAPHICS flag (which uses OpenGL) is planned to be deprecated for using Skia to access the GPU. Ideally with a Vulkan dep on Linux and Metal dep on macOS.

[ADKaster]

Ah. By 'soon', I actually mean 'already' LadybirdBrowser/ladybird#428

[nonetrix]

That's what I assumed that flag did sorry

[fgaz]

Thank you for informing us @ADKaster. Then I'll consider this closed when I finish #325045