Install app on macOS for neovide

[triarius]

Description of changes

Produce .App for neovide on macOS environments.

Fixes: #301984

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[matteo-pacini]

Thanks for your first contribution, please check Contributing.md to get more insights on how to build a great PR!

Title suggestion: neovide: add darwin app
Commit message suggestion: neovide: add darwin app

The app does not run properly on aarch64-darwin - I would be expect it to be wrapped so neovim is added to its PATH?

EDIT: See @ck3d comment below about relying on neovim being present on user system

[triarius]

Thanks for the informative comments @matteo-pacini. Looks I was a bit premature in making this PR. I thought it would work because I followed what was done in

nixpkgs/pkgs/applications/terminal-emulators/alacritty/default.nix

Lines 94 to 98 in 57d6973

	if stdenv.isDarwin then ''
	mkdir $out/Applications
	cp -r extra/osx/Alacritty.app $out/Applications
	ln -s $out/bin $out/Applications/Alacritty.app/Contents/MacOS
	'' else ''

, and it did indeed work on my machine. I'll educate myself a bit, and hopefully I can fix this. Meanwhile, I'll mark this PR as a draft.

[triarius]

Commit message suggestion: neovide: add darwin app

I assume it's acceptable to amend and force push to change the commit message? LMK what my alternative are otherwise.

[matteo-pacini]

Commit message suggestion: neovide: add darwin app

I assume it's acceptable to amend and force push to change the commit message? LMK what my alternative are otherwise.

@triarius It is, ideally for this kind of update there should be two commits:

• maintainer: add NAME
• neovide: add darwin build (or platform, as long as it makes sense)

Something else to keep in mind when producing macOS apps derivations (happened to me recently with #318047 and #318535 ).

• if you already have icons, no-codesigning to do, you're good to go

• If you need to convert PNGs to icns, you can pull in libicns and use png2icons to create a icns bundle (+ imagemagick if you need to do resizing)

• If you need codesigning (ad-hoc only I presume), you can pull in darwin.sigtool, that gives you an alternative codesign tool to do so

In your case, I think you only need to wrapProgram the final executable inside to app bundle so it can find the neovim executable.

[ck3d]

Neovide has no dependency to python3, please remove.
Neovide has a dependency to neovim, but we should rely on the user's environment. I think you increase the closure size of this package with no need. Further more, if the user installed in his environment, it would be ignored.

[triarius]

I've removed them. I only put them in because it was not working for @matteo-pacini, presumably because there, it was run in an environment with no neovim install.

[triarius]

Specifically, this:

The app does not run properly on aarch64-darwin - I would be expect it to be wrapped so neovim is added to its PATH?

But I see now that you both agree that it should use a neovim from the environment. So I've removed it.

[ck3d]

You created a wrapped neovide, but you use the unwrapped one, why?

[triarius]

My mistake, I misinterpreted this comment to mean I was not using the wrapped executable in the .app bundle. I then I thought .neovide-wrapped would be the wrapped one, as its name suggested. But I see now, by inspecting the neovide executable, that it's just a script that execs .neovim-wrapped. Hence, it is the wrapper for .neovide-wrapped.