corsix-th: darwin build, add maintainer

[matteo-pacini]

Description of changes

• Added darwin build to corsix-th.
• Added myself as second maintainer for Darwin.
• Added nix-update-script as passthru.updateScript

Tested on aarch64-darwin. Also rebuilt on aarch64-linux to ensure that my changes did not break stuff.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4061

[paparodeo]

• i don't see a reason to remove the finalAttrs pattern
• can put lua.withPackages in the buildInputs. no need for luaEnv attribute
• i think lua.withPackages brings in lua so can remove lua from buildInputs

suggested changes

diff --git a/pkgs/games/corsix-th/default.nix b/pkgs/games/corsix-th/default.nix
index d50c55a0718d..885de2612361 100644
--- a/pkgs/games/corsix-th/default.nix
+++ b/pkgs/games/corsix-th/default.nix
@@ -18,14 +18,14 @@
 , nix-update-script
 }:
 
-stdenv.mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
   pname = "corsix-th";
   version = "0.67";
 
   src = fetchFromGitHub {
     owner = "CorsixTH";
     repo = "CorsixTH";
-    rev = "v${version}";
+    rev = "v${finalAttrs.version}";
     hash = "sha256-WA/VJqHXzBfVUBNtxCVsGBRzSRQ0pvDvAy03ntc0KZE=";
   };
 
@@ -33,14 +33,12 @@ stdenv.mkDerivation rec {
     ./darwin-cmake-no-fixup-bundle.patch
   ];
 
-  luaEnv = lua.withPackages(p: with p; [ luafilesystem lpeg luasec luasocket ]);
   nativeBuildInputs = [ cmake doxygen makeWrapper ];
 
   buildInputs = [
     ffmpeg
     freetype
-    lua
-    luaEnv
+    (lua.withPackages(p: with p; [ luafilesystem lpeg luasec luasocket ]))
     SDL2
     SDL2_mixer
     timidity
@@ -74,4 +72,4 @@ stdenv.mkDerivation rec {
     maintainers = with maintainers; [ hughobrien matteopacini ];
     platforms = platforms.linux ++ platforms.darwin;
   };
-}
+})

alternatively if don't want to expand luaEnv can put it in a let.

buildInputs = let
  luaEnv = lua.withPackages(p: with p; [ luafilesystem lpeg luasec luasocket ]);
in
[
  ...
  luaEnv
  ...
];

[matteo-pacini]

@paparodeo removing lua yields an error during the game startup - not sure why, so I put it back in.

[paparodeo]

Result of nixpkgs-review pr 318535 run on x86_64-darwin 1

1 package built:

• corsix-th

---

Result of nixpkgs-review pr 318535 run on x86_64-linux 1

1 package built:

• corsix-th

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1734

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1745

[wegank]

Result of nixpkgs-review pr 318535 run on aarch64-darwin 1

1 package built:

• corsix-th