Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgsrip: init at 0.1.11 #316209

Merged
merged 3 commits into from
Dec 22, 2024
Merged

pgsrip: init at 0.1.11 #316209

merged 3 commits into from
Dec 22, 2024

Conversation

eljamm
Copy link
Contributor

@eljamm eljamm commented May 31, 2024

Description of changes

  • pgsrip: tool to rip PGS subtitles
  • trakit: guess additional information from track titles (dependency)
  • cleanit: command-line tool to clean subtitles (dependency)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 31, 2024
@eljamm eljamm added the backport release-24.05 Backport PR automatically label Jun 14, 2024
@eljamm
Copy link
Contributor Author

eljamm commented Jun 14, 2024

Result of nixpkgs-review pr 316209 run on x86_64-linux 1

8 packages built:
  • cleanit (python311Packages.cleanit)
  • cleanit.dist (python311Packages.cleanit.dist)
  • pgsrip (python311Packages.pgsrip)
  • pgsrip.dist (python311Packages.pgsrip.dist)
  • trakit (python311Packages.trakit)
  • trakit.dist (python311Packages.trakit.dist)
  • python312Packages.trakit
  • python312Packages.trakit.dist

@eljamm eljamm changed the title Python3Packages.pgsrip: init at 0.1.9 Python3Packages.pgsrip: init at 0.1.11 Jun 23, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024
@eljamm eljamm requested a review from natsukium as a code owner July 31, 2024 10:47
@eljamm eljamm removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 31, 2024
@eljamm
Copy link
Contributor Author

eljamm commented Jul 31, 2024

Result of nixpkgs-review pr 316209 run on x86_64-linux 1

12 packages built:
  • cleanit (python312Packages.cleanit)
  • cleanit.dist (python312Packages.cleanit.dist)
  • pgsrip (python312Packages.pgsrip)
  • pgsrip.dist (python312Packages.pgsrip.dist)
  • python311Packages.cleanit
  • python311Packages.cleanit.dist
  • python311Packages.pgsrip
  • python311Packages.pgsrip.dist
  • python311Packages.trakit
  • python311Packages.trakit.dist
  • trakit (python312Packages.trakit)
  • trakit.dist (python312Packages.trakit.dist)

@SuperSandro2000 SuperSandro2000 changed the title Python3Packages.pgsrip: init at 0.1.11 python3Packages.pgsrip: init at 0.1.11 Jul 31, 2024
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pgsrip/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pgsrip/default.nix Outdated Show resolved Hide resolved
@eljamm eljamm force-pushed the pgsrip branch 2 times, most recently from 921e094 to 122565c Compare July 31, 2024 12:31
@eljamm
Copy link
Contributor Author

eljamm commented Jul 31, 2024

Result of nixpkgs-review pr 316209 run on x86_64-linux 1

12 packages built:
  • cleanit (python312Packages.cleanit)
  • cleanit.dist (python312Packages.cleanit.dist)
  • pgsrip (python312Packages.pgsrip)
  • pgsrip.dist (python312Packages.pgsrip.dist)
  • python311Packages.cleanit
  • python311Packages.cleanit.dist
  • python311Packages.pgsrip
  • python311Packages.pgsrip.dist
  • python311Packages.trakit
  • python311Packages.trakit.dist
  • python312Packages.trakit
  • python312Packages.trakit.dist

@eljamm eljamm force-pushed the pgsrip branch 2 times, most recently from b24619e to b16949d Compare July 31, 2024 13:36
@eljamm
Copy link
Contributor Author

eljamm commented Jul 31, 2024

Moved pgsrip to be an application since we don't really need its module.


Result of nixpkgs-review run on x86_64-linux 1

10 packages built:
  • cleanit (python312Packages.cleanit)
  • cleanit.dist (python312Packages.cleanit.dist)
  • pgsrip
  • pgsrip.dist
  • python311Packages.cleanit
  • python311Packages.cleanit.dist
  • python311Packages.trakit
  • python311Packages.trakit.dist
  • python312Packages.trakit
  • python312Packages.trakit.dist

@eljamm eljamm requested a review from SuperSandro2000 July 31, 2024 13:38
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@eljamm eljamm changed the title python3Packages.pgsrip: init at 0.1.11 pgsrip: init at 0.1.11 Dec 21, 2024
@eljamm eljamm removed the backport release-24.05 Backport PR automatically label Dec 21, 2024
@eljamm eljamm removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 21, 2024
@eljamm
Copy link
Contributor Author

eljamm commented Dec 21, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 316209


x86_64-linux

✅ 10 packages built:
  • cleanit (python312Packages.cleanit)
  • cleanit.dist (python312Packages.cleanit.dist)
  • pgsrip
  • pgsrip.dist
  • python311Packages.cleanit
  • python311Packages.cleanit.dist
  • python311Packages.trakit
  • python311Packages.trakit.dist
  • python312Packages.trakit
  • python312Packages.trakit.dist

@eljamm
Copy link
Contributor Author

eljamm commented Dec 21, 2024

@ofborg build pgsrip

version = "0.1.11";
pyproject = true;

disabled = python3Packages.pythonOlder "3.9";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is a bit useless because python3Packages will never be 3.9 or below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not by default, but I don't think that it hurts to include this information in any case.

@SuperSandro2000 SuperSandro2000 merged commit 088f445 into NixOS:master Dec 22, 2024
51 of 53 checks passed
@eljamm eljamm deleted the pgsrip branch December 22, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants