Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icoextract: use thumbnailer from upstream #312909

Merged
merged 3 commits into from
Jul 12, 2024
Merged

icoextract: use thumbnailer from upstream #312909

merged 3 commits into from
Jul 12, 2024

Conversation

donovanglover
Copy link
Member

Description of changes

Fixes an issue where upstream updated the thumbnailer by fetching from GitHub instead of PyPI.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@donovanglover donovanglover mentioned this pull request May 19, 2024
Merged
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels May 19, 2024
@donovanglover donovanglover force-pushed the icoextract-cleanup branch 3 times, most recently from 591ab9a to 23bd177 Compare May 19, 2024 16:23
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 22, 2024
@donovanglover donovanglover removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 23, 2024
bryanasdev000
bryanasdev000 approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@bryanasdev000 bryanasdev000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff and ofborg LGTM.

Built locally and used the CLI.

Thanks!

@bryanasdev000 bryanasdev000 added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels May 26, 2024
@donovanglover
Copy link
Member Author

Rebased and updated the date

@ofborg ofborg bot requested a review from bryanasdev000 July 7, 2024 20:26
Aleksanaa
Aleksanaa reviewed Jul 10, 2024
View reviewed changes
pkgs/by-name/ic/icoextract/package.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-aliases.nix Outdated Show resolved Hide resolved
pkgs/by-name/ic/icoextract/package.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/bottles/default.nix Outdated Show resolved Hide resolved
@donovanglover
icoextract: migrate to by-name
a4630ce 
icoextract is primarily a command-line tool.

Also removes the no longer required pythonOlder check.
@donovanglover
icoextract: use thumbnailer from upstream
70123e0 
Fixes an issue where upstream updated the thumbnailer by fetching from
GitHub instead of PyPI.
@donovanglover
icoextract: set meta.mainProgram
0c5ebda
@donovanglover
Copy link
Member Author

Thanks, should be much better now

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes and removed 10.rebuild-darwin: 1 labels Jul 11, 2024
@natsukium natsukium merged commit 3a375fc into NixOS:master Jul 12, 2024
26 of 27 checks passed
@donovanglover donovanglover deleted the icoextract-cleanup branch August 2, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

@natsukium natsukium natsukium approved these changes

@psydvl psydvl Awaiting requested review from psydvl

@SCOTT-HAMILTON SCOTT-HAMILTON Awaiting requested review from SCOTT-HAMILTON

@bryanasdev000 bryanasdev000 Awaiting requested review from bryanasdev000

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@donovanglover @natsukium @Aleksanaa @bryanasdev000 @wegank