-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python311Packages.icoextract: 0.1.4 -> 0.1.5 #308618
python311Packages.icoextract: 0.1.4 -> 0.1.5 #308618
Conversation
@NixOS/nixpkgs-merge-bot merge |
@donovanglover merge not permitted (#305350): |
Result of 6 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BTW, can you update the thumbnailer in nixpkgs with the changes from upstream? |
That's a bot 🙃 |
Made a new PR for this: #312909 |
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.icoextract is: Extract icons from Windows PE files
meta.homepage for python311Packages.icoextract is: https://github.com/jlu5/icoextract
Updates performed
To inspect upstream changes
Impact
Checks done
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }'
run on x86_64-linux 16 packages built:
Maintainer pings
cc @bryanasdev000 @donovanglover for testing.