Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.icoextract: 0.1.4 -> 0.1.5 #308618

Merged

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented May 2, 2024

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python311Packages.icoextract is: Extract icons from Windows PE files

meta.homepage for python311Packages.icoextract is: https://github.com/jlu5/icoextract

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 0.1.5 with grep in /nix/store/4sp0yzwpfm528hffq16ghc2if47fp42x-python3.11-icoextract-0.1.5
  • found 0.1.5 in filename of file in /nix/store/4sp0yzwpfm528hffq16ghc2if47fp42x-python3.11-icoextract-0.1.5

Rebuild report (if merged into master) (click to expand)
5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath

bottles
bottles-unwrapped
python311Packages.icoextract
python312Packages.icoextract
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/4sp0yzwpfm528hffq16ghc2if47fp42x-python3.11-icoextract-0.1.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python311Packages.icoextract https://github.com/r-ryantm/nixpkgs/archive/7612072e80f4f4e082e18e982a734fd4c713acde.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/7612072e80f4f4e082e18e982a734fd4c713acde#python311Packages.icoextract

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/4sp0yzwpfm528hffq16ghc2if47fp42x-python3.11-icoextract-0.1.5
ls -la /nix/store/4sp0yzwpfm528hffq16ghc2if47fp42x-python3.11-icoextract-0.1.5/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

6 packages built:
  • bottles
  • bottles-unwrapped
  • python311Packages.icoextract
  • python311Packages.icoextract.dist
  • python312Packages.icoextract
  • python312Packages.icoextract.dist

Maintainer pings

cc @bryanasdev000 @donovanglover for testing.

@donovanglover donovanglover added 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels May 2, 2024
@donovanglover
Copy link
Member

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@donovanglover merge not permitted (#305350):
pkgs/development/python-modules/icoextract/default.nix is not in pkgs/by-name/

@fabaff
Copy link
Member

fabaff commented May 2, 2024

Result of nixpkgs-review pr 308618 run on x86_64-linux 1

6 packages built:
  • bottles
  • bottles-unwrapped
  • python311Packages.icoextract
  • python311Packages.icoextract.dist
  • python312Packages.icoextract
  • python312Packages.icoextract.dist

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@ofborg ofborg bot requested a review from donovanglover May 3, 2024 00:18
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donovanglover
Copy link
Member

BTW, can you update the thumbnailer in nixpkgs with the changes from upstream?

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels May 3, 2024
@Aleksanaa Aleksanaa merged commit c0d3974 into NixOS:master May 19, 2024
25 checks passed
@Aleksanaa
Copy link
Member

BTW, can you update the thumbnailer in nixpkgs with the changes from upstream?

That's a bot 🙃

@r-ryantm r-ryantm deleted the auto-update/python311Packages.icoextract branch May 19, 2024 12:18
@donovanglover
Copy link
Member

Made a new PR for this: #312909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants