Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: fix meta hooks #306444

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Apr 24, 2024

Description of changes

Closes #270805.

Based on #251418.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 24, 2024
@l0b0 l0b0 requested review from borisbabic and imincik April 24, 2024 09:57
@l0b0 l0b0 force-pushed the fix-pre-commit-meta-checks branch 2 times, most recently from 9477ccf to fc7cf6f Compare October 10, 2024 00:04
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@l0b0 l0b0 force-pushed the fix-pre-commit-meta-checks branch from fc7cf6f to e17593b Compare November 22, 2024 02:40
@l0b0 l0b0 changed the title pre-commit: test meta hooks pre-commit: fix meta hooks Nov 22, 2024
And add regression test.

Closes NixOS#270805.

Co-Authored-By: Matt Rixman <[email protected]>
@l0b0 l0b0 force-pushed the fix-pre-commit-meta-checks branch from e17593b to 291e11d Compare November 22, 2024 02:42
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 22, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 23, 2024
@symphorien symphorien merged commit 2911adf into NixOS:master Nov 23, 2024
51 of 52 checks passed
@l0b0 l0b0 deleted the fix-pre-commit-meta-checks branch November 23, 2024 21:03
@corngood
Copy link
Contributor

corngood commented Nov 26, 2024

I bisected a failure in python3Packages.asteroid-filterbanks to here (291e11d).

It looks like the propagated build inputs are causing pytestCheckPhase to run, where it didn't before.

asteroid-filterbanks -> pre-commit -> identify ->

  dependencies = [
    editdistance-s
    pytestCheckHook
    ukkonen
  ];

Edit: proposed fix in #359359

@corngood
Copy link
Contributor

corngood commented Nov 26, 2024

Removing the identify -> pytestCheckHook propagated dependency fixed python312Packages.asteroid-filterbanks, but python311.asteroid-filterbanks was still broken because of propagated dependencies from python 312.

I removed the dependency on pre-commit altogether for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit's meta checks missing dependencies
5 participants