pre-commit's meta checks missing dependencies

[l0b0]

Describe the bug

nix-shell --pure --run 'pre-commit run --all-files' fails with this message after moving from the nixos-23.05 channel to nixos-unstable:

Check hooks apply to the repository......................................Failed
- hook id: check-hooks-apply
- exit code: 1

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/nix/store/8icgy8r45srni7mqmh4ykj0m8d46c4z0-pre-commit-3.3.3/lib/python3.11/site-packages/pre_commit/meta_hooks/check_hooks_apply.py", line 7, in <module>
    from pre_commit import git
  File "/nix/store/8icgy8r45srni7mqmh4ykj0m8d46c4z0-pre-commit-3.3.3/lib/python3.11/site-packages/pre_commit/git.py", line 9, in <module>
    from pre_commit.util import CalledProcessError
  File "/nix/store/8icgy8r45srni7mqmh4ykj0m8d46c4z0-pre-commit-3.3.3/lib/python3.11/site-packages/pre_commit/util.py", line 16, in <module>
    from pre_commit import parse_shebang
  File "/nix/store/8icgy8r45srni7mqmh4ykj0m8d46c4z0-pre-commit-3.3.3/lib/python3.11/site-packages/pre_commit/parse_shebang.py", line 7, in <module>
    from identify.identify import parse_shebang_from_file
ModuleNotFoundError: No module named 'identify'

Check for useless excludes...............................................Failed
- hook id: check-useless-excludes
- exit code: 1

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/nix/store/8icgy8r45srni7mqmh4ykj0m8d46c4z0-pre-commit-3.3.3/lib/python3.11/site-packages/pre_commit/meta_hooks/check_useless_excludes.py", line 7, in <module>
    from cfgv import apply_defaults
ModuleNotFoundError: No module named 'cfgv'

Looks like missing runtime dependencies, but based on this it could possibly be a deeper problem?

Steps To Reproduce

Steps to reproduce the behavior:

1. Enable the check-hooks-apply and check-useless-excludes pre-commit "meta" hooks
2. Switch to nixpkgs 5a09cb4
3. Run pre-commit run --all-files

Expected behavior

This should run successfully, same as before the nixpkgs bump.

Notify maintainers

@borisbabic

Metadata

• system: "x86_64-linux"
• host os: Linux 6.1.63, NixOS, 23.05 (Stoat), 23.05.4969.1216a5ba22a9
• multi-user?: yes
• sandbox: yes
• version: nix-env (Nix) 2.13.6
• channels(root): "nixos-23.05, nixos-hardware"
• channels(username): ""
• nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Priorities

Add a 👍 reaction to issues you find important.