Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metacubexd: init at 1.140.0 #297721

Merged
merged 2 commits into from
Jun 10, 2024
Merged

metacubexd: init at 1.140.0 #297721

merged 2 commits into from
Jun 10, 2024

Conversation

Guanran928
Copy link
Contributor

Description of changes

Clash/Mihomo WebUIs, used with #287966

sigh, bun and pnpm.

https://github.com/MetaCubeX/metacubexd
https://github.com/haishanh/yacd

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Sorry, something went wrong.

@Guanran928
Copy link
Contributor Author

nixpkgs on  mihomo-webuis [$]
❯ nix build .#yacd --option substitute false

nixpkgs on  mihomo-webuis [$] took 19s
❯ ls result/
 _headers                           CNAME                  registerSW.js   yacd-128.png
 apple-touch-icon-precomposed.png   index.html             sw.js           yacd.ico
 assets                             manifest.webmanifest   yacd-64.png

nixpkgs on  mihomo-webuis [$]
❯ nix build .#metacubexd --option substitute false

nixpkgs on  mihomo-webuis [$]
❯ ls result/
 apple-touch-icon-180x180.png   index.html                  pwa-512x512.png
 assets                         manifest.webmanifest        registerSW.js
 env-vars                       maskable-icon-512x512.png   sw.js
 favicon.ico                    pwa-64x64.png               workbox-3e911b1d.js
󰕙 favicon.svg                    pwa-192x192.png

@Guanran928 Guanran928 changed the title meatcubexd, yacd: init metacubexd, yacd: init Mar 21, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 21, 2024
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 31, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3727

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3851

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others looks okay

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 9, 2024
pkgs/by-name/me/metacubexd/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ya/yacd/package.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

sigh, bun and pnpm.

With #290715 merged, does that make things easier and we can build from source?

@Guanran928
Copy link
Contributor Author

Guanran928 commented Jun 6, 2024 via email

@Guanran928
Copy link
Contributor Author

Guanran928 commented Jun 7, 2024

I haven't figured out lockfile errors while trying to build yacd, so I think I'm dropping it in this pr.

@Guanran928 Guanran928 changed the title metacubexd, yacd: init metacubexd: init at 1.140.0 Jun 7, 2024
@drupol drupol merged commit e27092e into NixOS:master Jun 10, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants