-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/mihomo: init #287966
nixos/mihomo: init #287966
Conversation
1e1a20c
to
af430c3
Compare
af430c3
to
9da59fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work!
232f48c
to
8868402
Compare
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3660 |
@ofborg test mihomo |
Hi, I got here from the release-notes because I didn't find anything that looks like a "rule-based proxy in Go" at the linked repo: MetaCubeX/mihomo. I don't understand Chinese so maybe one of the other links in the PR clarifies this, but are the release notes correct? |
About the naming and description issue please refer to #271658 (comment) |
Ok I found the actual project, it's in a non default branch. I think that that branch should be linked from the release notes instead of default branch which shows a project seemingly unrelated to the actual service exposed by the module. |
Feel free to write a PR changing URLs or other links and ping me for a review.
…On 7 April 2024 16:39:08 GMT+03:00, ThinkChaos ***@***.***> wrote:
Ok I found the actual project, it's in [a non default branch](https://github.com/MetaCubeX/mihomo/tree/meta-main). I think that that branch should be linked from the release notes instead of default branch which shows a project seemingly unrelated to the actual service exposed by the module.
Again maybe some info is lost in translation for me, but I suspect most people that read the release notes and check out the project will have the same confusion as I did.
--
Reply to this email directly or view it on GitHub:
#287966 (comment)
You are receiving this because you modified the open/close state.
Message ID: ***@***.***>
|
|
Description of changes
Adds a module for
clash-meta
, a rule-based proxy based on Go, similar to #250301.I'm new to Nix/NixOS and nixpkgs, please tell if I did anything wrong. ^^
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.