Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgsMusl.jdk8: mark broken for musl #281621

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

superherointj
Copy link
Contributor

pkgsMusl.jdk8: mark broken for musl

Tracking issue: #281618

error: ‘isnanf’ was not declared in this scope

CC @edwtjo

@superherointj
Copy link
Contributor Author

I'm not sure what is going on with CI:

image

@wegank
Copy link
Member

wegank commented Jan 17, 2024

@infinisil

@infinisil
Copy link
Member

infinisil commented Jan 17, 2024

Sorry for that! Was broken with #281407, but now already fixed with #281412, it's really easy to mess up the GitHub workflows since they're not tested by default 😅. You'll have to rebase unfortunately.

Tracking issue: NixOS#281618

error: ‘isnanf’ was not declared in this scope
@superherointj superherointj force-pushed the pkgsMusl.jdk8-mark-broken branch from b5a48a2 to c2ad2aa Compare January 17, 2024 20:32
@yu-re-ka
Copy link
Contributor

pkgsMusl.jdk8: mark broken for musl

I'm not sure if it makes sense to start marking everything as broken on musl that doesn't build. You are going to add a lot of broken = stdenv.isMusl in that case...

@superherointj
Copy link
Contributor Author

superherointj commented Jan 17, 2024

I'm not sure if it makes sense to start marking everything as broken on musl that doesn't build. You are going to add a lot of broken = stdenv.isMusl in that case...

Better than building it every time and finding out some inner dependency is broken. As Musl doesn't have cache, builds are longer.

Every PR I have opened to report breakage is specific to the package and not some downstream breakage. So, it is not all packages that are being marked broken but just the packages that need to be marked broken to avoid long builds.

Also, I find a chore and tiring having to do this. But someone has to do the dirty work.

Some problems have a known solution from others, so it is important to make it known what is broken, so others can chime in. For example, the php package, I got a helpful hint. And maintainers might have an interest in fixing their packages, which just happened to pony.

Once the specific broken packages are marked broken, the set of packages that are needed to be built is smaller, making build resource usage lower, hopefully enabling to cache musl. Cache is important for CI builds and to avoid regressions, such as this.

So it is a step in the right direction for the musl ecosystem to flourish.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 18, 2024
@superherointj superherointj added the awaiting_reviewer (old Marvin label, do not use) label Apr 11, 2024
@superherointj superherointj added 6.topic: musl Running or building packages with musl libc 6.topic: java Including JDK, tooling, other languages, other VMs labels Apr 18, 2024
@superherointj superherointj merged commit b860563 into NixOS:master Jul 12, 2024
23 checks passed
@superherointj superherointj deleted the pkgsMusl.jdk8-mark-broken branch July 12, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: musl Running or building packages with musl libc 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux awaiting_reviewer (old Marvin label, do not use)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants