-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkgsMusl.jdk8: mark broken for musl #281621
pkgsMusl.jdk8: mark broken for musl #281621
Conversation
Tracking issue: NixOS#281618 error: ‘isnanf’ was not declared in this scope
b5a48a2
to
c2ad2aa
Compare
I'm not sure if it makes sense to start marking everything as broken on musl that doesn't build. You are going to add a lot of |
Better than building it every time and finding out some inner dependency is broken. As Musl doesn't have cache, builds are longer. Every PR I have opened to report breakage is specific to the package and not some downstream breakage. So, it is not all packages that are being marked broken but just the packages that need to be marked broken to avoid long builds. Also, I find a chore and tiring having to do this. But someone has to do the dirty work. Some problems have a known solution from others, so it is important to make it known what is broken, so others can chime in. For example, the php package, I got a helpful hint. And maintainers might have an interest in fixing their packages, which just happened to pony. Once the specific broken packages are marked broken, the set of packages that are needed to be built is smaller, making build resource usage lower, hopefully enabling to cache musl. Cache is important for CI builds and to avoid regressions, such as this. So it is a step in the right direction for the musl ecosystem to flourish. |
pkgsMusl.jdk8: mark broken for musl
Tracking issue: #281618
CC @edwtjo