check-by-name/run-local.sh: Make it usable for non-CI platforms #281407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
force-pushed
the
by-name-local-run-platforms
branch
from
739451a to
c0ed22d
Compare
Since NixOS#281374, the nixpkgs-check-by-name tooling is pinned to a specific /nix/store path to avoid having to evaluate Nixpkgs in CI. The same path is used for local runs, but that doesn't actually work when you're trying to run it on a platform different from CI. This commit makes it work by being clearer about platforms and making local runs check out the correct Nixpkgs to evaluate the tool from.
infinisil
force-pushed
the
by-name-local-run-platforms
branch
from
c0ed22d to
9da57b5
Compare
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Jan 17, 2024
Wasn't detected in NixOS#281407
This was referenced Jan 17, 2024
infinisil
commented
Jan 17, 2024
| - name: Fetching the pinned tool | ||
| run: | | ||
| # Get the direct /nix/store path from the pin to avoid having to evaluate Nixpkgs | ||
| toolPath=$(jq -r .ci-path pkgs/test/nixpkgs-check-by-name/scripts/pinned-tool.json) |
There was a problem hiding this comment.
Should've tested this in a separate repository. This broke CI on master very briefly before I fixed it with #281412. Only two PRs were affected:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Since #281374, the nixpkgs-check-by-name tooling is pinned to a specific /nix/store path to avoid having to evaluate Nixpkgs in CI.
The same path is used for local runs, but that doesn't actually work when you're trying to run it on a platform different from CI:
This PR makes it work by being clearer about platforms and making local runs check out the correct Nixpkgs to evaluate the tool from.
Things done
run-local.sh mastersuccessfully onx86_64-linuxandaarch64-darwinupdate-pinned-tool.shfor the new format.Add a 👍 reaction to pull requests you find important.