Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry: fix tests on Darwin #281397

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jan 16, 2024

tests/console/commands/test_shell.py::test_shell used to fail with

shellingham.posix.ps.PsNotAvailable: ps not found

Description of changes

fixes #281369

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @Brawl345


Add a 👍 reaction to pull requests you find important.

tests/console/commands/test_shell.py::test_shell used to fail with

    shellingham.posix.ps.PsNotAvailable: ps not found
@dotlambda dotlambda added the 6.topic: darwin Running or building packages on Darwin label Jan 16, 2024
@dotlambda
Copy link
Member Author

@ofborg build poetry

@Brawl345
Copy link
Contributor

Tested on aarch64-darwin, works, thanks! 👍

@ofborg ofborg bot requested a review from jbaum98 January 17, 2024 05:12
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Jan 17, 2024
@dotlambda dotlambda marked this pull request as ready for review January 17, 2024 05:12
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 17, 2024
@dotlambda dotlambda merged commit a11119e into NixOS:master Jan 17, 2024
30 of 32 checks passed
@dotlambda dotlambda deleted the poetry-fix-darwin branch January 17, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: poetry on macOS ARM64
2 participants