Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: devenv and poetry update #288

Merged
merged 1 commit into from
Jan 17, 2024
Merged

chore: devenv and poetry update #288

merged 1 commit into from
Jan 17, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Jan 17, 2024

No description provided.

@ss2165 ss2165 requested a review from aborgna-q January 17, 2024 16:49
devenv.nix Outdated
Comment on lines 54 to 56
# normal package is 1.71.0 which seems to break on arm macos
# this installs 1.4.2 instead
package = pkgs-stable.poetry;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that the last working version? It looks old.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NixOS/nixpkgs#281397

it was fixed 11 hours ago so added that as the source

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(now v1.7.1)

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65eed46) 83.80% compared to head (0bb68f7) 83.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files          35       35           
  Lines        4452     4452           
  Branches     4305     4305           
=======================================
  Hits         3731     3731           
  Misses        523      523           
  Partials      198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ss2165 ss2165 added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 9e941f3 Jan 17, 2024
11 checks passed
@ss2165 ss2165 deleted the chore/updates branch January 17, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants