Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacsPackages.codeium: refactor with melpaBuild #278918

Merged
merged 1 commit into from
Jan 6, 2024
Merged

emacsPackages.codeium: refactor with melpaBuild #278918

merged 1 commit into from
Jan 6, 2024

Conversation

running-grass
Copy link
Contributor

@running-grass running-grass commented Jan 5, 2024 •
edited
Loading

Description of changes

refactor build from trivialBuild to melpaBuild

Resolve this conversation

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: emacs Text editor label Jan 5, 2024
@running-grass running-grass requested a review from jian-lin January 5, 2024 11:25
@running-grass running-grass mentioned this pull request Jan 5, 2024
Merged
13 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1358

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1359

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 5, 2024
jian-lin
jian-lin approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@jian-lin jian-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could you rebase these commits into one?

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 5, 2024
@running-grass
Copy link
Contributor Author

LGTM

Could you rebase these commits into one?

over

@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 5, 2024
@jian-lin jian-lin merged commit 868769d into NixOS:master Jan 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jian-lin jian-lin jian-lin approved these changes

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: emacs Text editor 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@running-grass @nixos-discourse @AndersonTorres @jian-lin @delroth