emacsPackages.codeium: init at 1.6.13 #278201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
close #273977 |
|
Result of 1 package built:
|
running-grass
force-pushed
the
init-codeiumel
branch
from
fdee27a to
c6137eb
Compare
|
Result of 1 package built:
|
adisbladis
reviewed
Jan 2, 2024
pkgs/applications/editors/emacs/elisp-packages/manual-packages/codeium/default.nix
Show resolved
Hide resolved
adisbladis
reviewed
Jan 2, 2024
pkgs/applications/editors/emacs/elisp-packages/manual-packages/codeium/default.nix
Show resolved
Hide resolved
ofborg
bot
added
8.has: package (new)
adisbladis
reviewed
Jan 2, 2024
pkgs/applications/editors/emacs/elisp-packages/manual-packages/codeium/default.nix
Outdated
Show resolved
Hide resolved
|
Everything code-wise LGTM now. Could you squash your commits as described in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md ? |
running-grass
force-pushed
the
init-codeiumel
branch
from
2dfd927 to
4a703f1
Compare
13 tasks
jian-lin
reviewed
Jan 4, 2024
| @@ -0,0 +1,28 @@ | |||
| { trivialBuild, fetchFromGitHub, pkgs, lib, }: | |||
| trivialBuild { | |||
There was a problem hiding this comment.
Please use melpBuild or elpaBuild.
Packages built by trivialBuild will not be activated[1][2] by Emacs's builtin package manager package.el when Emacs starts. So some issues occur:
- autoloaded commands does not work out-of-the-box: you have to call
(require 'foo-autoloads)first before calling an autoloaded command - info manual does not show in
C-h i
Maybe this issue of trivialBuild should be documented somewhere? @adisbladis @AndersonTorres
[1]: its package dir is not searched by Emacs
[2]: it does not contain a foo-pkg.el file
There was a problem hiding this comment.
Resolved it with #278918
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Free, ultrafast, extensible AI code completion tool for Emacs
https://github.com/Exafunction/codeium.el
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.