prefetch-npm-deps: read url bodies within the retry loop

[lilyinstarlight]

Description of changes

Fixes issues with prefetch-npm-deps not properly retrying on network errors by reading the full body within the retry loop (rather than processing the request in the retry loop but then reading the body after)

Closes #257805
Closes #256873
Closes #258428

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[Gerg-L]

works for me

$ nix build github:nixos/nixpkgs#bitwarden --option substituters ''
error: builder for '/nix/store/a49pbxzg99z3j8yi8n27ibb1r0w73r90-bitwarden-2023.9.0-npm-deps.drv' failed with exit code 1;
       last 10 log lines:
       > node_modules/dir-compare/node_modules/minimatch
       > node_modules/through2-filter
       > node_modules/static-module/node_modules/magic-string
       > node_modules/@babel/plugin-transform-unicode-sets-regex
       > node_modules/@babel/plugin-syntax-export-namespace-from
       > node_modules/stat-mode
       > Error: unknown error
       >
       > Caused by:
       >     [55] Failed sending data to the peer
       For full logs, run 'nix log /nix/store/a49pbxzg99z3j8yi8n27ibb1r0w73r90-bitwarden-2023.9.0-npm-deps.drv'.
error (ignored): error: cannot unlink '/tmp/nix-build-openssh-9.5p1.drv-0': Directory not empty
error: 1 dependencies of derivation '/nix/store/531n38krd1jxbycp954sg5cm1fp2p6w4-bitwarden-2023.9.0.drv' failed to build
$

vs

$ nix build github:lilyinstarlight/nixpkgs/fix/prefetch-npm-deps-network-error-recovery#bitwarden --option substituters ''
$

[amarshall]

Ran nix-build -A bitwarden.npmDeps --check 20 times on 48 cores with no failures! Thanks!

[Gerg-L]

LGTM

[lilyinstarlight]

That last push was to change the method name a bit to clarify its change in behavior. It should just be a cosmetic/semantic change rather than a functional one

[github-actions]

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-260011-to-release-23.05 origin/release-23.05
cd .worktree/backport-260011-to-release-23.05
git checkout -b backport-260011-to-release-23.05
ancref=$(git merge-base a2b87a4f66f309d2f4b789fd0457f5fc5db0a9a6 554e2412e0b4a89f527786e67d568d9cf3842d80)
git cherry-pick -x $ancref..554e2412e0b4a89f527786e67d568d9cf3842d80

[lilyinstarlight]

Manual backport is in #260742 (backport failure was due to #255168 not having been merged, but #260742 supersedes that one now)