fetch-npm-deps: Reduce flaky network issues by limiting parallelism #258428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes fails flaky with errors like: > [55] Failed sending data to the peer that are difficult to reproduce at times, and cause a lot of frustration as the general answer is to just keep retrying. Testing with `nix-build --check -A bitwarden.npmDeps`, I got these results: - 2 cores: 20 / 20 runs succeeded in ~35 min total - 4 cores: 18 / 20 runs succeeded in ~17 min total - 8 cores: 11 / 20 runs succeeded in ~ 8 min total This isn’t the ideal solution as it doesn’t fix the problem, but it is at least something to temper the frequent flaky failures without sacrificing too much runtime. See NixOS#256873 NixOS#257805
12 tasks
|
Can you see if #260011 fixes the issue? |
|
Closing in favor of #260011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Sometimes fails flaky with errors like:
that are difficult to reproduce at times, and cause a lot of frustration as the general answer is to just keep retrying.
Testing with
nix-build --check -A bitwarden.npmDeps, I got these results:This isn’t the ideal solution as it doesn’t fix the problem, but it is at least something to temper the frequent flaky failures without sacrificing too much runtime.
See
#256873
#257805
Things done
Have only tested
bitwarden.npmDeps, assuming given the context of the change that it will not cause problems for other dependents.sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)