Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] rpcs3: enable building on darwin #246132

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[WIP] rpcs3: enable building on darwin #246132

wants to merge 1 commit into from
+23 −6

Conversation

vs49688
Copy link
Contributor

@vs49688 vs49688 commented Jul 30, 2023

Description of changes

Attempting to get rpcs3 compiling on Darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package labels Jul 30, 2023
@ofborg ofborg bot requested review from ilian and abbradar July 30, 2023 03:21
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 30, 2023
@vs49688 vs49688 force-pushed the rpcs3 branch 2 times, most recently from 5e8557e to 24a0283 Compare July 30, 2023 04:37
@ofborg ofborg bot added 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 30, 2023
@vs49688
Copy link
Contributor Author

vs49688 commented Jul 30, 2023

@ofborg build rpcs3

@vs49688 vs49688 mentioned this pull request Jul 30, 2023
Merged
12 tasks
@vs49688 vs49688 added the 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed label Aug 2, 2023
@vs49688
Copy link
Contributor Author

vs49688 commented Aug 2, 2023

Blocked until Apple SDKs are sorted out, see #242666

@vs49688 vs49688 changed the title rpcs3: enable building on darwin [WIP] rpcs3: enable building on darwin Aug 2, 2023
@vs49688 vs49688 force-pushed the rpcs3 branch 2 times, most recently from 4076d98 to f160d2f Compare November 22, 2023 16:34
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 22, 2023
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilian ilian Awaiting requested review from ilian

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
2.status: blocked by pr/issue Another PR or issue is preventing this from being completed 2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vs49688 @wegank