Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcs3: 0.0.27-14840-842edbcbe -> 0.0.28-15372-38a5313ed #244501

Merged
merged 1 commit into from
Jul 29, 2023
Merged

rpcs3: 0.0.27-14840-842edbcbe -> 0.0.28-15372-38a5313ed #244501

merged 1 commit into from
Jul 29, 2023

Conversation

vs49688
Copy link
Contributor

@vs49688 vs49688 commented Jul 20, 2023

Description of changes

Update rpcs3.

  • Cubeb support is unconditional now, remove the check.
  • SDL is only required for FAudio, so rename the check to faudioSupport.
  • Use system LLVM now that upstream supports it 🎉
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@vs49688
Copy link
Contributor Author

vs49688 commented Jul 20, 2023

@ofborg build rpcs3

@ofborg ofborg bot requested review from abbradar and ilian July 20, 2023 16:38
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 20, 2023
AndersonTorres
AndersonTorres suggested changes Jul 21, 2023
View reviewed changes
pkgs/applications/emulators/rpcs3/default.nix Outdated Show resolved Hide resolved
pkgs/applications/emulators/rpcs3/default.nix Outdated Show resolved Hide resolved
pkgs/applications/emulators/rpcs3/default.nix Outdated Show resolved Hide resolved
@vs49688
rpcs3: 0.0.27-14840-842edbcbe -> 0.0.28-15372-38a5313ed
be13164 
* Cubeb support is unconditional now, remove the check.
* SDL is only required for FAudio, so rename the check to faudioSupport.
* Use system LLVM now that upstream supports it 🎉
@vs49688 vs49688 changed the title rpcs3: 0.0.27-14840-842edbcbe -> 0.0.28-15368-a0297933c rpcs3: 0.0.27-14840-842edbcbe -> 0.0.28-15372-38a5313ed Jul 22, 2023
@vs49688
Copy link
Contributor Author

vs49688 commented Jul 22, 2023

@ofborg build rpcs3

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2478

@AndersonTorres
Copy link
Member

@ofborg build pkgsLLVM.rpcs3

@AndersonTorres
Copy link
Member

It does not run on Darwin. Let's merge!

@AndersonTorres AndersonTorres merged commit e6ab469 into NixOS:master Jul 29, 2023
@vs49688
Copy link
Contributor Author

vs49688 commented Jul 30, 2023

It does not run on Darwin. Let's merge!

I didn't know it could actually run on Darwin... I'll give it a crack 🤔

@vs49688
Copy link
Contributor Author

vs49688 commented Jul 30, 2023

@AndersonTorres I tried: #246132

https://logs.ofborg.org/?attempt_id=a0f25cb3-bee0-4590-b8d4-241a23416796&key=nixos%2Fnixpkgs.246132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres requested changes

@abbradar abbradar Awaiting requested review from abbradar

@ilian ilian Awaiting requested review from ilian

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vs49688 @nixos-discourse @AndersonTorres