Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rabbitmq-server: 3.10.8 -> 3.11.2 #200315

Merged
merged 1 commit into from
Jan 17, 2023
Merged

rabbitmq-server: 3.10.8 -> 3.11.2 #200315

merged 1 commit into from
Jan 17, 2023

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 9, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from turion November 9, 2022 01:54
@turion
Copy link
Contributor

turion commented Nov 9, 2022

Why does the test segfault on x86_64-darwin?

@ajs124
Copy link
Member Author

ajs124 commented Nov 9, 2022

Apparently erlangR25 does not build on x86_64-darwin? cc @NixOS/beam

@happysalada
Copy link
Contributor

Ok good to know, i havent had a chance to test or debug, will put it in the todo list

@ajs124
Copy link
Member Author

ajs124 commented Jan 17, 2023

Why does the test segfault on x86_64-darwin?

Considering #169956, we should just ignore that failure.

Also the test stopped evaluating due to a combination of #169644 and #201859

@happysalada
Copy link
Contributor

@GrahamcOfBorg eval

@happysalada happysalada merged commit 76b1584 into NixOS:master Jan 17, 2023
@happysalada
Copy link
Contributor

I agree here.
I took forthcoming steps and merged since i didnt expect a rush of opinions on this one. Happy to reconsider if anyone feels strongly against this

@DianaOlympos
Copy link
Contributor

DianaOlympos commented Jan 17, 2023 •
edited
Loading

Agree with the merge. Erlang cross-compilation in nixpkgs has been broken for quite some time (i would like to have it for graviton2 instances in AWS) but I have never been able to figure out how to fix it. I spent a week on it, and I feel like I understand even less now than before the experiment. Cross-compilation in nixpkgs feels like there is no-one able to help us with that anymore. And it is not helped by the erlang bootstrap process being fairly invovled

I would love to take another stab at it, but I feel I need help from an expert in nixpkgs cross-compilation for that.

@ajs124 ajs124 deleted the upd/rabbitmq branch January 17, 2023 13:43
@yorickvP
Copy link
Contributor

RabbitMQ 3.11 is not backwards compatible with earlier versions. Steps should be taken before upgrading. https://blog.rabbitmq.com/posts/2022/07/required-feature-flags-in-rabbitmq-3.11/

Please write a release note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turion turion Awaiting requested review from turion

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajs124 @turion @happysalada @DianaOlympos @yorickvP