Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbitmq-java-client: out of date #169644

Open
2 tasks done
armeenm opened this issue Apr 21, 2022 · 4 comments
Open
2 tasks done

rabbitmq-java-client: out of date #169644

armeenm opened this issue Apr 21, 2022 · 4 comments
Assignees
Labels
6.topic: java Including JDK, tooling, other languages, other VMs 9.needs: package (update) This needs a package to be updated

Comments

@armeenm
Copy link
Contributor

armeenm commented Apr 21, 2022

Lives here now. Out of date and depends on python2. Last touched July 2014.

Checklist
Project name

nix search name:

current version: 3.3.4
desired version: 5.14.2

Notify maintainers

maintainers: NONE!

Note for maintainers

Please tag this issue in your PR.

@armeenm armeenm added the 9.needs: package (update) This needs a package to be updated label Apr 21, 2022
@veprbl veprbl added the 6.topic: java Including JDK, tooling, other languages, other VMs label Apr 23, 2022
@smancill
Copy link
Contributor

smancill commented Jul 9, 2022

I do not use rabbitmq, but I did upgrade this package just to learn how to do a Maven derivation, and I see no point in doing it.

I can create the same amqp-client-5.15.0.jar artifact than the one in the download page (same list of classes at least), and that's all there is. A simple packaged library with no entry point for a command line application.

The current, very old, derivation provides a single wrapped script to run some performance test as a binary, alongside the library and all its dependencies packaged together. But the up to date way to run test according to the README is through Maven inside the source directory. So, there is no such script to package in the output. There are no test classes in the output artifact. Just the library.

I'd argue to remove this derivation. It has no use. No other package uses it as dependency (it's not something that happens with Java, dependencies are downloaded from Maven repos, otherwise Nix would have to package thousands of new Java packages for dependencies), and it's just a library, no CLI to run.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 8, 2023
@ajs124
Copy link
Member

ajs124 commented Jan 17, 2023

It's used by the rabbitmq nixos test, so having a working version would be quite useful. Or we also remove it from the test.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 17, 2023
@tomodachi94
Copy link
Member

I'll take a look at this package tomorrow. Looks like the latest version is 5.17.0, but we're on 3.11.2.

@tomodachi94 tomodachi94 self-assigned this May 21, 2023
@tomodachi94 tomodachi94 added this to Java Nov 10, 2024
@tomodachi94 tomodachi94 moved this to Todo in Java Nov 13, 2024
@tomodachi94
Copy link
Member

This isn't as simple as it appears. It now depends on a Python module; it is available in rabbitmq-server's src, but it is not installed into that derivation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: java Including JDK, tooling, other languages, other VMs 9.needs: package (update) This needs a package to be updated
Projects
Status: To do
Development

No branches or pull requests

5 participants