-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release-22.05] maintainers: add Scrumplex and minion3665, tomlplusplus: init at 3.2.0, prismlauncher: init at 5.0 #196721
[Backport release-22.05] maintainers: add Scrumplex and minion3665, tomlplusplus: init at 3.2.0, prismlauncher: init at 5.0 #196721
Conversation
Signed-off-by: Sefa Eyeoglu <[email protected]> Signed-off-by: Skyler Grey <[email protected]>
Signed-off-by: Sefa Eyeoglu <[email protected]>
77538e1
to
f9b1cf5
Compare
@ofborg eval |
Result of 1 package built:
|
Given that #196624 will need to be backported manually, I'd like to wait until it's merged before merging this so we can put it in the same PR |
- Previously PolyMC was the suggested replacement for MultiMC - As PolyMC is marked as insecure and prismlauncher is a replacement, this commit suggests using it instead
Result of 1 package blacklisted:
2 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds and runs, tested a few instances migrated from polymc and seems to be working fine.
- Previously PolyMC was the suggested alternative - This commit replaces that with prismlauncher, as PolyMC is no longer secure
github = "Scrumplex"; | ||
githubId = 11587657; | ||
keys = [{ | ||
longkeyid = "rsa2048/0xC10411294912A422"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI you should regenerate a GPG key with more bits some time
Description of changes
This is a manual backport of #196624, as well as all its dependencies
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes