Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pridefetch: init at 1.0.0 #174095

Merged
merged 2 commits into from
Jun 2, 2022
Merged

pridefetch: init at 1.0.0 #174095

merged 2 commits into from
Jun 2, 2022

Conversation

Minion3665
Copy link
Member

@Minion3665 Minion3665 commented May 23, 2022 •
edited
Loading

Description of changes
  • Add myself to the maintainer-list.nix
  • Create the pridefetch package at version 1.0.0
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 23, 2022
Mindavi
Mindavi requested changes May 28, 2022
View reviewed changes
Copy link
Contributor

@Mindavi Mindavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we accept maintainer additions from people that aren't planning on being a nixpkgs maintainer.

@Minion3665
Copy link
Member Author

I don't think we accept maintainer additions from people that aren't planning on being a nixpkgs maintainer.

Alright; I'll add the package that I have made for pridefetch to nixpkgs as well as planned, although I will do so in this PR rather than separate PRs

@Minion3665 Minion3665 changed the title maintainers: add minion3665 pridefetch: init at 1.0.0 May 28, 2022
@Minion3665 Minion3665 force-pushed the add-myself-to-maintainers branch from 331dfb4 to 7a35d18 Compare May 28, 2022 22:58
@Minion3665 Minion3665 marked this pull request as draft May 28, 2022 23:01
@Minion3665 Minion3665 marked this pull request as ready for review May 28, 2022 23:15
@Minion3665 Minion3665 requested a review from Mindavi May 28, 2022 23:15
Mindavi
Mindavi requested changes May 28, 2022
View reviewed changes
pkgs/tools/misc/pridefetch/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pridefetch/default.nix Show resolved Hide resolved
pkgs/tools/misc/pridefetch/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pridefetch/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pridefetch/default.nix Outdated Show resolved Hide resolved
@Minion3665 Minion3665 marked this pull request as draft May 29, 2022 00:24
@Minion3665 Minion3665 closed this May 29, 2022
@Minion3665 Minion3665 force-pushed the add-myself-to-maintainers branch from 7a35d18 to 26e7906 Compare May 29, 2022 00:40
@Minion3665 Minion3665 reopened this May 29, 2022
@Minion3665 Minion3665 marked this pull request as ready for review May 29, 2022 00:56
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 29, 2022
@Minion3665 Minion3665 requested a review from Mindavi May 29, 2022 01:17
@Minion3665 Minion3665 mentioned this pull request May 29, 2022
Closed
ncfavier
ncfavier reviewed May 29, 2022
View reviewed changes
Copy link
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remarks. https://github.com/jtojnar/nixpkgs-hammering can help find some of them.

pkgs/tools/misc/pridefetch/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pridefetch/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pridefetch/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pridefetch/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pridefetch/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pridefetch/default.nix Outdated Show resolved Hide resolved
@Minion3665 Minion3665 force-pushed the add-myself-to-maintainers branch from 2d05f77 to ba20e94 Compare May 29, 2022 20:41
@Minion3665
Copy link
Member Author

A few remarks. jtojnar/nixpkgs-hammering can help find some of them.

Thank you very much for your help and suggesting use of nixpkgs-hammering! I decided to keep the build step and install step separate, as I think that the build step here creates the executable and the install step installs it

ncfavier
ncfavier reviewed May 29, 2022
View reviewed changes
Copy link
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final nit!

pkgs/tools/misc/pridefetch/default.nix Outdated Show resolved Hide resolved
@Minion3665
pridefetch: init at 1.0.0
f598554 
pridefetch is a cli tool to display system information (similarly
to neofetch or pfetch) in your terminal along with a pride flag.
@Minion3665 Minion3665 force-pushed the add-myself-to-maintainers branch from ba20e94 to f598554 Compare May 29, 2022 21:16
@Mindavi
Copy link
Contributor

Mindavi commented May 29, 2022

Already looks quite good, some small things to look at and then I think it'll be ok for now.

@Minion3665 Minion3665 requested a review from Mindavi May 30, 2022 01:00
@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 31, 2022
@Mindavi
Copy link
Contributor

Mindavi commented Jun 2, 2022

This looks fine. Maybe a simple installCheck test could be added in a followup, if you'd like.

@Mindavi Mindavi merged commit 767f59c into NixOS:master Jun 2, 2022
@Minion3665 Minion3665 deleted the add-myself-to-maintainers branch June 2, 2022 18:48
@Minion3665 Minion3665 mentioned this pull request Oct 19, 2022
Merged
13 tasks
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncfavier ncfavier ncfavier approved these changes

@Mindavi Mindavi Mindavi approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Minion3665 @Mindavi @ncfavier @bobby285271 @Janik-Haag