Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseaudio: fix evaluation with Nix 2.3 #188466

Merged
merged 1 commit into from
Aug 27, 2022

Conversation

sternenseemann
Copy link
Member

Path interpolation syntax has been introduced in Nix 2.4 and may not be
used in nixpkgs which needs to be able to be evaluated with Nix 2.3.

cc fyi @wegank

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Path interpolation syntax has been introduced in Nix 2.4 and may not be
used in nixpkgs which needs to be able to be evaluated with Nix 2.3.
@sternenseemann sternenseemann marked this pull request as ready for review August 27, 2022 08:12
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 27, 2022
@adisbladis adisbladis merged commit e87c5b9 into NixOS:master Aug 27, 2022
@sternenseemann sternenseemann deleted the fix-eval-2.3 branch August 27, 2022 08:45
@wegank
Copy link
Member

wegank commented Aug 27, 2022

Oh I actually opened #188275 for this. I guess that PR can be closed now.

@sternenseemann
Copy link
Member Author

If it's still dead code, I guess it could be removed regardless, I don't know.

@ncfavier
Copy link
Member

ncfavier commented Jan 1, 2023

BTW, why are we still supporting Nix 2.3? The 22.05 channel has 2.8...

@wegank
Copy link
Member

wegank commented Jan 1, 2023

Probably #204371 (comment) . Also FreshPorts' Nix is on 2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants