Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval tests should be executed with the lowest supported Nix version (2.3) #612

Open
sternenseemann opened this issue Aug 27, 2022 · 4 comments

Comments

@sternenseemann
Copy link
Member

I ran into the first instance of path interpolation syntax slipping into nixpkgs today: NixOS/nixpkgs#188466. Our lib/minver.nix prescribes that we support everything from 2.3 upwards.

Without CI to catch it, it is quite understandable that contributors accidentally introduce such changes (who remembers the changelog precisely?). Running the eval checks on the oldest supported Nix version should be enough, as any accepted Nix expressions under 2.3 should be forwards compatible.

@ghost
Copy link

ghost commented Mar 12, 2023

I made this mistake too: NixOS/nixpkgs#210207

OfBorg really needs to check this.

@SuperSandro2000
Copy link
Member

This would also remove all performance optimizations done since the minimum supported versions.

@infinisil
Copy link
Member

This is now implemented in Nixpkgs directly: NixOS/nixpkgs@013acf2

@ShamrockLee
Copy link

Here is the explanation by @infinisil about the minimum supported Nix version on NixOS Discourse:

https://discourse.nixos.org/t/when-is-a-nix-builtin-function-builtins-considered-ready-to-be-used-inside-nixpkgs/35369/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants