Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.ipython: disable failing clipboard test on darwin #161216

Closed
wants to merge 1 commit into from

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Fixes #160133

A fairly straightforward fix, as suggested in #160133 (comment)

The comment on the upstream test makes it sound non-critical, so I think disabling it is the sensible solution.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin (via rosetta)
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 21, 2022
@thefloweringash thefloweringash changed the title ipython: disable failing clipboard test on darwin python3Packages.ipython: disable failing clipboard test on darwin Feb 21, 2022
@zowoq
Copy link
Contributor

zowoq commented Feb 21, 2022

Also fixed in #159516 but it is in staging.

cc @mweinelt @vcunat

@thefloweringash
Copy link
Member Author

Also fixed in #159516 but it is in staging.

cc @mweinelt @vcunat

Oh, I thought it was strange that it wasn't already fixed! Sorry for the noise. I'll make a comment on the ticket I thought I was fixing.

@vcunat
Copy link
Member

vcunat commented Feb 21, 2022

The ticked contains a suggestion how to do it without rebuilds (on other platforms), so you could go that way if it's urgent. It seems likely that staging will take a week or two (or three).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python3Packages.ipython is failing on x86_64-darwin (master)
3 participants