python3Packages.ipython: disable clipboard test on darwin

[mweinelt]

Motivation for this change

#157584 (comment)

Probably to big to into master, but easier to test on master. Can be rebased later.

cc @NixOS/darwin-maintainers please test

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[vcunat]

Uh, its another of the parameters that would better not change hash if added with an empty list :-/ But... with null it wouldn't be extremely ugly and it would avoid rebuild except where needed (and failed anyway).

[mweinelt]

Wondering if the solution is as simple as

diff --git a/pkgs/development/interpreters/python/hooks/pytest-check-hook.sh b/pkgs/development/interpreters/python/hooks/pytest-check-hook.sh
index 0f708f88829..26aa614426e 100644
--- a/pkgs/development/interpreters/python/hooks/pytest-check-hook.sh
+++ b/pkgs/development/interpreters/python/hooks/pytest-check-hook.sh
@@ -33,12 +33,12 @@ function pytestCheckPhase() {
 
     # Compose arguments
     args=" -m pytest"
-    if [ -n "$disabledTests" ]; then
+    if [ "${#disabledTests[@]}" -gt 0 ]; then
         disabledTestsString=$(_pytestComputeDisabledTestsString "${disabledTests[@]}")
       args+=" -k \""$disabledTestsString"\""
     fi
 
-    if [ -n "${disabledTestPaths-}" ]; then
+    if [ "${#disabledTestPaths[@]}" -gt 0 ]; then
         eval "disabledTestPaths=($disabledTestPaths)"
     fi
 

Edit: nope, isn't.

[vcunat]

The solution has to be in evaluation time, i.e. shell can't do it. On a quick glance, replacing empty lists by null values might even be a reasonable default for mkDerivation and similar functions.

[vcunat]

Anyway, let's try this particular build
@ofborg build python3Packages.ipython

[risicle]

WFM macos 10.15

[mweinelt]

Rebased, sorry for the noise. Need to learn how to do it properly I guess.