Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fakeroot: 1.23 -> 1.27 #158311

Merged
merged 1 commit into from
Feb 6, 2022
Merged

fakeroot: 1.23 -> 1.27 #158311

merged 1 commit into from
Feb 6, 2022

Conversation

ius
Copy link
Contributor

@ius ius commented Feb 6, 2022

Motivation for this change

Resolves #140138, closes #154367

I was able to verify most patches were applied upstream, all that remains is:

This fixes fakeroot on RISC-V (#101651)

Before merging

One patch (Darwin only) which was dropped

Someone running Darwin should investigate whether this is still required. If it is, please provide an updated patch

Things done
  • Built on platform(s)
    • x86_64-linux
    • riscv64-linux (qemu)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ius
Copy link
Contributor Author

ius commented Feb 6, 2022

@mroi: can you check whether this regresses #122832 and/or provide an updated patch?

@roberth
Copy link
Member

roberth commented Feb 6, 2022

Could you rebase? That will get you a passthru.tests test case as well. I merged that today, unaware of your PR until I browsed the PR list.

@siraben
Copy link
Member

siraben commented Feb 6, 2022

Result of nixpkgs-review pr 158311 run on aarch64-darwin 1

1 package built:
  • fakeroot

@siraben siraben merged commit 2944776 into NixOS:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fakeroot 1.26 update request
3 participants