Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fakeroot: fix Darwin by applying an additional patch from Brew #122832

Merged
merged 1 commit into from
May 16, 2021

Conversation

mroi
Copy link
Contributor

@mroi mroi commented May 13, 2021

I was testing cross-building of Linux Docker images on macOS hosts. It almost works except for a runtime linker error with libfakeroot. The reason is that the patchset ported over from Brew is currently incomplete. One additional patch is missing, but it needs to be applied to a generated file, so an intermediate make as to run first.

I ported the change from the fakeroot Brew formula. The patch is explained upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 13, 2021
@ofborg ofborg bot requested a review from viric May 13, 2021 13:57
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 13, 2021

Result of nixpkgs-review pr 122832 at a474001 run on aarch64-linux 1

4 packages built successfully:
  • autofs5
  • fakeroot
  • hylafaxplus
  • sssd

Result of nixpkgs-review pr 122832 at a474001 run on x86_64-linux 1

6 packages built successfully:
  • autofs5
  • cdesktopenv
  • fakeroot
  • hylafaxplus
  • sssd
  • virtualboxWithExtpack
4 suggestions:
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/tools/system/fakeroot/default.nix:20:5:

       |
    20 |     (fetchpatch {
       |     ^
    
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/tools/system/fakeroot/default.nix:15:5:

       |
    15 |     (fetchpatch {
       |     ^
    
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/tools/system/fakeroot/default.nix:25:5:

       |
    25 |     (fetchpatch {
       |     ^
    
  • warning: build-tools-in-build-inputs

    getopt is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/tools/system/fakeroot/default.nix:32:3:

       |
    32 |   buildInputs = [ getopt gnused ]
       |   ^
    

@roberth roberth merged commit beae2e6 into NixOS:master May 16, 2021
@mroi mroi deleted the patch-fakeroot branch May 17, 2021 14:23
@ius ius mentioned this pull request Feb 6, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants