Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-index: 0.1.2 -> unstable-2022-03-07 #153229

Merged
merged 1 commit into from
Mar 14, 2022
Merged

nix-index: 0.1.2 -> unstable-2022-03-07 #153229

merged 1 commit into from
Mar 14, 2022

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 2, 2022 •
edited
Loading

Motivation for this change
  • nix-index hasn't had a stable release since Sep 2018 (more than 3 years)
  • update to unstable to support aarch64-darwin
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@prusnak prusnak mentioned this pull request Jan 2, 2022
Merged
13 tasks
@ofborg ofborg bot requested review from bennofs and ncfavier January 2, 2022 18:14
@prusnak prusnak marked this pull request as draft January 2, 2022 18:57
@prusnak
Copy link
Member Author

prusnak commented Jan 2, 2022

Hm, it seems that latest master fails on Linux. @bennofs any ideas?

https://logs.nix.ci/?key=nixos/nixpkgs.153229&attempt_id=43162d0a-ab06-4676-a7e0-38be8975c576

@lutzmor
Copy link

lutzmor commented Jan 2, 2022

I checked the PR on my x86_64-darwin and there nix-index failes also.
WIth the following error ( https://pastebin.com/zKr2r3zU )

@prusnak
Copy link
Member Author

prusnak commented Jan 2, 2022

I checked the PR on my x86_64-darwin and there nix-index failes also.

Commit aa2e4fce3938d21bd7bf11c53c15ade1060bd1ae works for me on x86_64-darwin (and CI seems to agree: https://github.com/NixOS/nixpkgs/pull/153229/checks?check_run_id=4685494070)

@lutzmor
Copy link

lutzmor commented Jan 2, 2022

I checked the PR on my x86_64-darwin and there nix-index failes also.

Commit aa2e4fc works for me on x86_64-darwin (and CI seems to agree: https://github.com/NixOS/nixpkgs/pull/153229/checks?check_run_id=4685494070)

Okay will double check maybe something is broken on my side! Sry

@siraben
Copy link
Member

siraben commented Jan 3, 2022

Result of nixpkgs-review pr 153229 run on x86_64-darwin 1

2 packages built:
  • nix-index
  • nix-index-unwrapped

@FlorianFranzen
Copy link
Contributor

Just as on the CI, this currently fails to build for me. It looks like the example in the comment in src/workset.rs is interpreted as a test case, so this will have to be disabled.

@ncfavier
Copy link
Member

Should be fixed now: nix-community/nix-index@9fc9441.

@prusnak can you update this to the latest master? (we really need an update now nix-community/nix-index#179)

@prusnak prusnak changed the title nix-index: 0.1.2 -> unstable-2021-11-13 nix-index: 0.1.2 -> unstable-2022-03-07 Mar 13, 2022
@prusnak prusnak marked this pull request as ready for review March 13, 2022 22:38
@prusnak
Copy link
Member Author

prusnak commented Mar 13, 2022

@prusnak can you update this to the latest master?

Updated and force pushed. Ready for review.

@ncfavier
Copy link
Member

Result of nixpkgs-review pr 153229 run on x86_64-linux 1

3 packages built:
  • comma
  • nix-index
  • nix-index-unwrapped

ncfavier
ncfavier approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine runs fine, let's wait for CI

SuperSandro2000
SuperSandro2000 reviewed Mar 13, 2022
View reviewed changes
pkgs/tools/package-management/nix-index/default.nix
};

cargoSha256 = "161lz96a52s53rhhkxxhcg41bsmh8w6rv6nl8gwqmg3biszy7hah";
cargoSha256 = "sha256-2Yhnacsx8EWsfZfcfKhV687cblyFDmsfdqGZoK6Lulo=";

nativeBuildInputs = [ pkg-config ];
buildInputs = [ openssl curl ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we activate tests all the time now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Addressed in c9f623a

@ofborg ofborg bot requested a review from ncfavier March 14, 2022 09:22
ncfavier
ncfavier approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@prusnak prusnak merged commit 0745b85 into NixOS:master Mar 14, 2022
@prusnak prusnak deleted the nix-index branch March 14, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncfavier ncfavier ncfavier approved these changes

@bennofs bennofs Awaiting requested review from bennofs

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@prusnak @lutzmor @siraben @FlorianFranzen @ncfavier @SuperSandro2000