Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comma: init at 1.1.0 #150431

Merged
merged 1 commit into from
Jan 8, 2022
Merged

comma: init at 1.1.0 #150431

merged 1 commit into from
Jan 8, 2022

Conversation

Enzime
Copy link
Member

@Enzime Enzime commented Dec 12, 2021 •
edited by siraben
Loading

Motivation for this change

Fixes nix-community/comma#2

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Enzime
Copy link
Member Author

Enzime commented Dec 13, 2021

@GrahamcOfBorg build comma

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/663

0x4A6F
0x4A6F approved these changes Jan 2, 2022
View reviewed changes
Copy link
Member

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested on x86_64-linux.

@Enzime
Copy link
Member Author

Enzime commented Jan 2, 2022

Just fixed the maintainers variable

@0x4A6F
Copy link
Member

0x4A6F commented Jan 2, 2022

Dependency nix-index doesn't build on aarch64-darwin, any @NixOS/darwin-maintainers aware of this?

@prusnak
Copy link
Member

prusnak commented Jan 2, 2022

Dependency nix-index doesn't build on aarch64-darwin, any @NixOS/darwin-maintainers aware of this?

nix-index hasn't had a stable release since 2018 - this PR #153229 updates nix-index to unstable to support aarch64-darwin build

Artturin
Artturin requested changes Jan 3, 2022
View reviewed changes
pkgs/tools/package-management/comma/default.nix Outdated Show resolved Hide resolved
pkgs/tools/package-management/comma/default.nix Outdated Show resolved Hide resolved
@Enzime Enzime changed the title comma: init at 1.0.0 comma: init at 1.1.0 Jan 3, 2022
@Enzime Enzime requested a review from Artturin January 3, 2022 13:27
@siraben
Copy link
Member

siraben commented Jan 3, 2022

Result of nixpkgs-review pr 150431 run on x86_64-darwin 1

1 package built:
  • comma

@0x4A6F
Copy link
Member

0x4A6F commented Jan 8, 2022

Thanks. Any objections for merging this? Should we wait for #153229?

siraben
siraben approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@siraben siraben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend merging since we have two major platforms supported.

@0x4A6F 0x4A6F merged commit 959d10e into NixOS:master Jan 8, 2022
@Enzime Enzime deleted the add/comma branch January 8, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@0x4A6F 0x4A6F 0x4A6F approved these changes

@siraben siraben siraben approved these changes

@DavHau DavHau Awaiting requested review from DavHau

@Artturin Artturin Awaiting requested review from Artturin

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add to Nixpkgs
7 participants
@Enzime @nixos-discourse @0x4A6F @prusnak @siraben @veprbl @Artturin