Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixops: remove (v1.x) #150059

Closed
wants to merge 1 commit into from
Closed

nixops: remove (v1.x) #150059

wants to merge 1 commit into from

Conversation

roberth
Copy link
Member

@roberth roberth commented Dec 10, 2021

Motivation for this change

NOTE: a preferable solution may be feasible #154715

The NixOps 1.x branch has been unsupported for a long time, breaks
very often in Nixpkgs, because it requires heavily outdated deps,
and has put undue burden on the python packages maintainers.

The 1.x branch is unsustainable and it is time that we acknowledge
this fact. The only way forward for NixOps is the unreleased
version 2.0, which needs testing and fixes before it can be
released and become the replacement for the default nixops package.

As mentioned before: #144627 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

cc @AmineChikhaoui @eelco @rob

The NixOps 1.x branch has been unsupported for a long time, breaks
very often in Nixpkgs, because it requires heavily outdated deps,
and has put undue burden on the python packages maintainers.

The 1.x branch is unsustainable and it is time that we acknowledge
this fact. The only way forward for NixOps is the unreleased
version 2.0, which needs testing and fixes before it can be
released and become the replacement for the default nixops package.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 10, 2021
@@ -32548,7 +32548,7 @@ with pkgs;

nixStatic = pkgsStatic.nix;

nixops = callPackage ../tools/package-management/nixops { };
nixops = builtins.throw "The NixOps 1.x branch is unmaintained and unsupported. Please upgrade to nixopsUnstable and contribute to the NixOps 2 release.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go in aliases, I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why that would be useful. Isn't it nicer to keep the nixops attrs together? Will make the 2.0 release slightly easier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use aliases to prevent all-packages.nix from being cluttered with 100's of deprecation/removal errors.

@roberth roberth marked this pull request as draft December 13, 2021 13:21
@siraben
Copy link
Member

siraben commented Jan 11, 2022

Any updates on this?

@adisbladis
Copy link
Member

Fwiw: I think this is sad and a testament to how badly Python package maintenance works in nixpkgs.
We have all the technical requisites for these problems never to occur, yet here we are.

adisbladis added a commit to adisbladis/nixpkgs that referenced this pull request Jan 12, 2022
The NixOps derivation keeps breaking because of unrelated Python packaging work and is incredibly difficult to keep alive.
Rather than outright removing 1.7 as suggested in NixOS#150059 this change shuold make it much easier to keep 1.7 on life support without causing any burden for those wanting to work on python3 only.
@Artturin
Copy link
Member

Solved by #154715

Thanks all!

@Artturin Artturin closed this Feb 19, 2022
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Oct 10, 2022
The NixOps derivation keeps breaking because of unrelated Python packaging work and is incredibly difficult to keep alive.
Rather than outright removing 1.7 as suggested in NixOS#150059 this change shuold make it much easier to keep 1.7 on life support without causing any burden for those wanting to work on python3 only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants