-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixops: remove (v1.x) #150059
nixops: remove (v1.x) #150059
Conversation
The NixOps 1.x branch has been unsupported for a long time, breaks very often in Nixpkgs, because it requires heavily outdated deps, and has put undue burden on the python packages maintainers. The 1.x branch is unsustainable and it is time that we acknowledge this fact. The only way forward for NixOps is the unreleased version 2.0, which needs testing and fixes before it can be released and become the replacement for the default nixops package.
@@ -32548,7 +32548,7 @@ with pkgs; | |||
|
|||
nixStatic = pkgsStatic.nix; | |||
|
|||
nixops = callPackage ../tools/package-management/nixops { }; | |||
nixops = builtins.throw "The NixOps 1.x branch is unmaintained and unsupported. Please upgrade to nixopsUnstable and contribute to the NixOps 2 release."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can go in aliases, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why that would be useful. Isn't it nicer to keep the nixops attrs together? Will make the 2.0 release slightly easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use aliases to prevent all-packages.nix from being cluttered with 100's of deprecation/removal errors.
Any updates on this? |
Fwiw: I think this is sad and a testament to how badly Python package maintenance works in nixpkgs. |
The NixOps derivation keeps breaking because of unrelated Python packaging work and is incredibly difficult to keep alive. Rather than outright removing 1.7 as suggested in NixOS#150059 this change shuold make it much easier to keep 1.7 on life support without causing any burden for those wanting to work on python3 only.
Solved by #154715 Thanks all! |
The NixOps derivation keeps breaking because of unrelated Python packaging work and is incredibly difficult to keep alive. Rather than outright removing 1.7 as suggested in NixOS#150059 this change shuold make it much easier to keep 1.7 on life support without causing any burden for those wanting to work on python3 only.
Motivation for this change
NOTE: a preferable solution may be feasible #154715
The NixOps 1.x branch has been unsupported for a long time, breaks
very often in Nixpkgs, because it requires heavily outdated deps,
and has put undue burden on the python packages maintainers.
The 1.x branch is unsustainable and it is time that we acknowledge
this fact. The only way forward for NixOps is the unreleased
version 2.0, which needs testing and fixes before it can be
released and become the replacement for the default nixops package.
As mentioned before: #144627 (comment)
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notescc @AmineChikhaoui @eelco @rob