Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staging-next: 21.11 iteration 1 #144730

Merged
merged 406 commits into from
Nov 15, 2021
Merged

staging-next: 21.11 iteration 1 #144730

merged 406 commits into from
Nov 15, 2021

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Nov 5, 2021

Another staging-next iteration. Documentation here: https://nixos.org/manual/nixpkgs/stable/#submitting-changes-staging-next-branch

https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents

Per the release schedule we are still restricted to non-breaking changes to release critical packages, and the plan is to merge in about a week (Nov 12).

Next staging-next: #146259

symphorien and others added 30 commits October 25, 2021 20:52
Current release lacks dependencies on local espeak-ng:

    cd dictsource && ESPEAK_DATA_PATH=/build/espeak-ng LD_LIBRARY_PATH=../src: \
        ../src/espeak-ng --compile=yue && cd ..
    bash: line 1: ../src/espeak-ng: No such file or directory

Should be fixed in next release: espeak-ng/espeak-ng#1029
Can't apply patch as is as Makefile.am diverged quite a bit since 1.50
release.
* FluidSynth 1.1.11 was kept around as a dependency of some packages
  that hadn't yet adjusted to API breakages. All of these packages now
  use FluidSynth 2.x, so fluidsynth_1 can be removed. It has been broken
  ever since glib was updated to 2.70 and was affected by an unpatched
  CVE.

* Refactor expression a bit, use pname instead of name.

* Add changelog entry in case someone was using this downstream
  (accidentally?).

Fixes #141508.
Fixes #124624.
espeak-ng: explicitly disable parallel building
glib: follow profile updates when searching apps
Signed-off-by: Felix Singer <[email protected]>
@nrdxp
Copy link

nrdxp commented Nov 13, 2021

Looks like we are a day behind on this. Anything holding up the merge? I'd like to help get this merged by EOD at least, if possible.

@fabianhjr
Copy link
Member

@nrdxp, not sure if a blocker but the only issue I am aware of is firefox: #144670.

Jon Ringer reported no regressions otherwise.

@fabianhjr
Copy link
Member

Regarding that issue, it seems like there is some approval for a fix: #145459 (3 hours ago) that should ideally be merged into staging-next.

@sternenseemann
Copy link
Member

@nrdxp, not sure if a blocker but the only issue I am aware of is firefox: #144670.

There are other big ones like libreoffice and thunderbird, likely more. As it stands we absolutely can't merge as the unstable jobset doesn't succeed.

Seems like Jon's build report doesn't really hold anymore.

@vcunat
Copy link
Member Author

vcunat commented Nov 13, 2021

Hydra's take on this, though some new failures were apparently temporary and will disappear on restart: https://hydra.nixos.org/eval/1721869?compare=1721771

I noticed the libreoffice regression mentioned a bit above, too. Nothing else stood out to me, though in the comparison there still are over 10k unfinished builds.

Currently `clangUseLLVM` is broken since it uses libcxx and compiler-rt but
also specifies `--gcc-toolchain`, which leads to weird compile errors when
including C++ headers.
@jonringer
Copy link
Contributor

@nrdxp, not sure if a blocker but the only issue I am aware of is firefox: #144670.

There are other big ones like libreoffice and thunderbird, likely more. As it stands we absolutely can't merge as the unstable jobset doesn't succeed.

Seems like Jon's build report doesn't really hold anymore.

It was my third time attempting to review it. if there are flakey builds then it's possible i just got lucky a few times.

github-actions bot and others added 6 commits November 14, 2021 00:01
[staging-next] libreoffice*: update and fix build
This reverts commit c7aef6d.

I believe it should work again since today, though I'm being a bit
conservative, pushing to `staging-next` instead of `master`.
@sternenseemann

This comment has been minimized.

@sternenseemann
Copy link
Member

Merged again to include evaluation fix bdaf941 for the issue introduced in 6fe9972 while resolving a conflict in the first merge.

@yu-re-ka
Copy link
Contributor

Runs on my systems just fine now. Firefox and Thunderbird work as well.

hyperscan, which is optionally used by rspamd, doesn't build.

@vcunat
Copy link
Member Author

vcunat commented Nov 15, 2021

https://hydra.nixos.org/eval/1722344?compare=1722301#tabs-now-fail

We're certainly not perfect, but to me this PR seems OK for master.

@vcunat vcunat merged commit 64065d7 into master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: kernel The Linux kernel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: rust 6.topic: stdenv Standard environment 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: systemd 6.topic: vim 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.