Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf: 3.18.0 -> 3.19.0 #142096

Merged
merged 2 commits into from
Oct 27, 2021
Merged

protobuf: 3.18.0 -> 3.19.0 #142096

merged 2 commits into from
Oct 27, 2021

Conversation

arcz
Copy link
Member

@arcz arcz commented Oct 18, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor

marsam commented Oct 23, 2021

Protobuf 3.19.0 was released a couple of days ago, would you mind updating to it?
Also you need to target to staging due the number of rebuilds

@arcz arcz changed the base branch from master to staging October 26, 2021 23:08
@arcz arcz changed the title protobuf: 3.18.0 -> 3.18.1 protobuf: 3.18.0 -> 3.19.0 Oct 26, 2021
@arcz
Copy link
Member Author

arcz commented Oct 26, 2021

@marsam done

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 27, 2021
marsam
marsam approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@marsam marsam merged commit dbf16dc into NixOS:staging Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arcz @marsam